Personal_mirrors/bitburner-src
1
0
Fork 0
mirror of https://github.com/bitburner-official/bitburner-src.git synced 2024-12-22 22:22:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2247 from MartinFournier/feature/alert-close-browser

Browse Source 
Add warning on game close if user launched external browser
This commit is contained in:
hydroflame 2022-01-02 11:44:56 -05:00 committed by GitHub
commit 1819e5a98a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
electron/gameWindow.js
View File

@ -32,6 +32,8 @@ async function createWindow(killall) {
// and open every other protocols on the browser
e.preventDefault();
shell.openExternal(url);
global.app_playerOpenedExternalLink = true;
});
window.webContents.backgroundThrottling = false;

14
electron/main.js
View File

@ -1,6 +1,6 @@
/* eslint-disable no-process-exit */
/* eslint-disable @typescript-eslint/no-var-requires */
const { app, BrowserWindow } = require("electron");
const { app, dialog, BrowserWindow } = require("electron");
const log = require("electron-log");
const greenworks = require("./greenworks");
const api = require("./api-server");
@ -33,6 +33,18 @@ function setStopProcessHandler(app, window, enabled) {
// Shutdown the http server
api.disable();
// Because of a steam limitation, if the player has launched an external browser,
// steam will keep displaying the game as "Running" in their UI as long as the browser is up.
// So we'll alert the player to close their browser.
if (global.app_playerOpenedExternalLink) {
await dialog.showMessageBox({
title: 'Bitburner',
message: 'You may have to close your browser to properly exit the game.',
detail: 'Steam will keep tracking Bitburner as "Running" if any process started within the game is still running.' +
' This includes launching an external link, which opens up your browser.',
type: 'warning', buttons: ['OK']
});
}
// We'll try to execute javascript on the page to see if we're stuck
let canRunJS = false;
window.webContents.executeJavaScript('window.stop(); document.close()', true)