Personal_mirrors/bitburner-src
1
0
Fork 0
mirror of https://github.com/bitburner-official/bitburner-src.git synced 2025-03-13 13:52:33 +01:00
Code Issues Packages Projects Releases Wiki Activity

CODEBASE: Show error dialog when finding out old bugs in pre-v2.4.0 (#1816)

Browse Source 
* CODEBASE: Show error dialog when finding out old bugs in pre-v2.4.0

* Only show error dialog once
This commit is contained in:
catloversg
2024-12-01 06:31:44 +07:00
committed by GitHub
parent 9c7223f876
commit 7a4b3e23c1
3 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/NetscriptWorker.ts
View File

@ -37,6 +37,7 @@ import { CompleteRunOptions, getRunningScriptsByArgs } from "./Netscript/Netscri
import { handleUnknownError } from "./utils/ErrorHandler";
import { isLegacyScript, legacyScriptExtension, resolveScriptFilePath, ScriptFilePath } from "./Paths/ScriptFilePath";
import { root } from "./Paths/Directory";
import { exceptionAlert } from "./utils/helpers/exceptionAlert";
export const NetscriptPorts = new Map<PortNumber, Port>();
@ -278,8 +279,11 @@ function processNetscript1Imports(code: string, workerScript: WorkerScript): { c
export function startWorkerScript(runningScript: RunningScript, server: BaseServer, parent?: WorkerScript): number {
if (server.hostname !== runningScript.server) {
// Temporarily adding a check here to see if this ever triggers
console.error(
`Tried to launch a worker script on a different server ${server.hostname} than the runningScript's server ${runningScript.server}`,
exceptionAlert(
new Error(
`Tried to launch a worker script on a different server ${server.hostname} than the runningScript's server ${runningScript.server}`,
),
true,
);
return 0;
}

12
src/Server/ServerHelpers.ts
View File

@ -11,6 +11,7 @@ import { Server as IServer } from "@nsdefs";
import { workerScripts } from "../Netscript/WorkerScripts";
import { killWorkerScriptByPid } from "../Netscript/killWorkerScript";
import { serverMetadata } from "./data/servers";
import { exceptionAlert } from "../utils/helpers/exceptionAlert";
/**
* Constructs a new server, while also ensuring that the new server
@ -206,9 +207,16 @@ export function prestigeHomeComputer(homeComp: Server): void {
homeComp.messages.push(LiteratureName.HackersStartingHandbook);
if (homeComp.runningScriptMap.size !== 0) {
// Temporary verbose logging section to gather data on a bug
console.error("Some runningScripts were still present on home during prestige");
exceptionAlert(
new Error(
`Some runningScripts were still present on home during prestige. runningScripts: ${Array.from(
homeComp.runningScriptMap.keys(),
)}`,
),
true,
);
for (const [scriptKey, byPidMap] of homeComp.runningScriptMap) {
console.error(`script key: ${scriptKey}: ${byPidMap.size} scripts`);
console.error(`script key: ${scriptKey}: ${byPidMap.size} scripts`, byPidMap);
for (const pid of byPidMap.keys()) {
if (workerScripts.has(pid)) killWorkerScriptByPid(pid);
}

2
src/utils/SaveDataMigrationUtils.ts
View File

@ -480,7 +480,7 @@ Error: ${e}`,
);
}
if (ver < 33) {
// 2.3.2 fixed what should be the last issue with scripts having the wrong server assigned..
// 2.4.0 fixed what should be the last issue with scripts having the wrong server assigned
for (const server of GetAllServers()) {
for (const script of server.scripts.values()) {
if (script.server !== server.hostname) {