rubenwardy
8b010c5a9f
ContentDB: Fix ungraceful crash on aliases when list download fails
...
Fixes #12267 and fixes #12154
2022-05-14 18:33:42 +02:00
sfan5
1e7b5d6fdb
Fix synchronization issue at thread start
...
If a newly started thread immediately exits then m_running would
immediately be set to false again and the caller would be stuck
waiting for m_running to become true forever.
Since a mutex for synchronizing startup already exists we can
simply move the while loop into it.
see also: #5134 which introduced m_start_finished_mutex
2022-05-14 18:33:42 +02:00
sfan5
a55982e7f0
Fix password changing getting stuck if wrong password is entered once
2022-05-14 18:33:42 +02:00
sfan5
1ac378063e
Apply disallow_empty_password to password changes too
2022-05-14 18:33:42 +02:00
sfan5
d497c92684
Fix race condition in registration leading to duplicate create_auth calls
2022-05-14 18:33:42 +02:00
paradust7
677dc2c155
Remove HW_buffer_counter after IrrlichtMt fix to remove HWBufferMap ( #12232 )
...
Keep code and use version check instead, for backwards compatibility
2022-05-14 18:33:42 +02:00
Alex
beea8deeb5
Fix invalid queued package element and path ( #12218 )
2022-05-14 18:33:42 +02:00
Giuseppe Bilotta
0d0f1a2fb2
Fix some textures not being sent correctly to older clients
...
Since b2eb44afc50976dc0954c868977b5829f3ff8a19, a texture defined as
`[combine:16x512:0,0=some_file.png;etc`
will not be sent correctly from a 5.5 server to a 5.4 client due to the
overeager detection of unsupported base modifier `[` introducing a
spurious `blank.png^` before the modifier.
Fix this by whitelisting which base modifiers can be passed through
unchanged to the client, and prefix `blank.png` for the others
(which at the moment is just [png:, but the list may grow larger
as new base modifiers are added.)
2022-05-14 18:33:42 +02:00
paradust7
439701ed7a
Fix '[combine' when EVDF_TEXTURE_NPOT is disabled. ( #12187 )
...
Stop scaling images to POT immediately when loaded. The 'combine'
modifier hardcodes X and Y coordinates, and so behaves incorrectly
if applied to a scaled image. Images emitted by generateImage()
are already scaled to POT before being used as a texture, so
nothing should break.
2022-05-14 18:33:42 +02:00
ShadowNinja
d945d0129c
Fix OOB read in trim("")
2022-05-14 18:33:42 +02:00
Dmitry Kostenko
cc91477308
Avoid negation of comparison operator (luacheck warning)
2022-05-14 18:33:42 +02:00
Daroc Alden
ac139ec03d
Fix memory leak in EmergeManager
...
EmergeManager keeps a copy of the BiomeGen that it creates, but
never deletes it.
2022-05-14 18:33:42 +02:00
Gregor Parzefall
b4f0e834bf
Fix footsteps for players whose collision box min y != 0 ( #12110 )
2022-05-14 18:33:42 +02:00
Daroc Alden
6e6cdc834f
Fix undefined behavior in TileLayer ( #12125 )
...
Initialize the values properly
2022-05-14 18:33:42 +02:00
Daroc Alden
4b81ae1b35
Fix memory leak from SpatialAreaStore ( #12120 )
2022-05-14 18:33:42 +02:00
sfan5
d569dc45a8
Fix segfault with autoscale_mode (again)
...
closes #12100
This time add some asserts so there is no misunderstanding about the NULL-ness of layer->texture.
2022-05-14 18:33:42 +02:00
sfan5
23d49fda29
Clean up ClientReady packet handling
...
fixes #12073
2022-05-14 18:33:42 +02:00
pecksin
62ad2c3bc1
Use absolute value for bouncy in collision ( #11969 )
...
[backport: removed devtest change and protocol_version comparison]
2022-05-14 18:33:42 +02:00
sfan5
25373ad294
Remove awful Mingw32 workarounds
...
Instead a warning is triggered if an affected compiler is detected.
closes #12022
2022-05-12 11:36:50 +02:00
sfan5
26d0c0fd8d
Fix broken server startup if curl is disabled ( #12046 )
2022-05-12 11:36:39 +02:00
Lars Mueller
3afffcd36b
Fix builtin statbar backgrounds
...
see #12000
2022-05-12 11:36:11 +02:00
sfan5
ec9f157512
Use native packer to transfer globals into async env(s)
2022-05-10 22:37:42 +02:00
Jude Melton-Houghton
7f58887ae3
Support packing arbitrary graphs ( #12289 )
2022-05-10 22:37:33 +02:00
Jude Melton-Houghton
d17d7eba14
Fix cooking and fuel crafts with aliases
2022-05-10 22:37:05 +02:00
Zughy
4fb4991f5e
Add doc to list breaking changes for the next major release
2022-05-10 22:36:50 +02:00
Octavian
0f8c46771e
Fix possible unreliable behavior due to uninitialized variables
2022-05-10 22:36:25 +02:00
sfan5
f5a8593b11
Add more Prometheus metrics ( #12274 )
2022-05-09 21:20:58 +02:00
Lars Müller
c2898f53bc
HUD: Update selection mesh every frame ( #12270 )
...
Fixes outdated selection boxes after entity property changes.
2022-05-09 20:43:47 +02:00
Lars Müller
089797dbe6
Fix Minetest blaming the wrong mod for errors ( #12241 )
...
Covers the case where mods insert their callbacks manually into "minetest.registered_<callbacks>" (often to achieve a particular order of execution).
2022-05-09 20:42:43 +02:00
Lars Müller
53c70b5f27
Docs: Recommend self.name
( #12239 )
2022-05-09 20:41:47 +02:00
sfan5
a66e6d4dff
Consolidate some data structures in MapBlockMesh
2022-05-08 19:12:10 +02:00
sfan5
1fa4f58080
Cache serialized mapblocks during sending
...
This reduces the
(absolute) time spent in Server::SendBlocks() from 700ms to 300ms
(relative) share of MapBlock::serialize() from 80% to 60%
in a test setup with 10 players and many block changes
2022-05-08 19:12:10 +02:00
sfan5
7fff9da71d
item_entity: Cache collisionbox for use in on_step
...
I don't have absolute numbers but if calls to get_properties() take up
30%+ of on_step() execution time that's bound to matter.
2022-05-08 19:12:10 +02:00
ROllerozxa
f128f4cba1
Fix mapblock geometry optimisation not working
...
Caused by the depth sorting PR marking not only transparent nodes to be ignored but also opaque ones with the TILE_MATERIAL_BASIC material type
2022-05-08 19:11:44 +02:00
Zughy
6f0c966877
Remove unused variable WARN_INIT
2022-05-08 19:11:15 +02:00
Jude Melton-Houghton
f10a260301
Enable dependencies when enabling modpacks ( #12202 )
2022-05-08 16:21:59 +01:00
Jude Melton-Houghton
54bc8a7627
Fix enabling of dependencies with identical names ( #12253 )
2022-05-08 14:14:14 +01:00
rubenwardy
9824a451bb
Fix mods not being recursively enabled
...
Fixes #12290
2022-05-08 14:01:32 +01:00
rubenwardy
e0e897832c
Fix texture packs showing as "Nil (enabled)" in Content tab
...
Fixes #12285
2022-05-07 23:05:39 +01:00
paradust7
87472150bc
Add benchmarks for json string serialize/deserialize ( #12258 )
...
Co-authored-by: sfan5 <sfan5@live.de>
2022-05-06 21:17:16 +01:00
Froggo
45d318a773
Enable chat clickable weblinks by default ( #12115 )
...
Co-authored-by: rubenwardy <rw@rubenwardy.com>
2022-05-06 21:15:16 +01:00
sfan5
4e1de06782
Bump IrrlichtMt to 1.9.0mt5 in CI
2022-05-06 15:16:04 +02:00
sfan5
8735a85a30
Declare all bundled libs as static
...
Otherwise it can happen that these are built as shared depending on the
options passed to CMake, which obviously isn't intended.
2022-05-06 15:16:04 +02:00
sfan5
e108954633
Sort out some issues with our CI setup
...
* add missing apt-get update where needed
* move some jobs to run on ubuntu-20.04
* update actions plugins to latest
* speed up the job that runs multiplayer tests
2022-05-06 15:15:53 +02:00
LoneWolfHT
47cf257c40
Fix Windows Visual Studio actions ( #11176 )
...
Co-authored-by: rubenwardy <rw@rubenwardy.com>
2022-05-04 22:55:02 +01:00
x2048
cc56ebd90d
Avoid rendering invisible faces of simple nodeboxes ( #12262 )
...
* Skip rendering faces adjacent to opaque nodes
* Cancel out opposite faces of adjacent nodebox nodes of the same type
Fixes #6409
2022-05-04 23:44:55 +02:00
Lars Müller
89c82035d8
hud_get: Return precision field for waypoints ( #12215 )
2022-05-04 20:55:20 +02:00
SmallJoker
3ce5a68cd1
guiScalingFilter: Fix most memory leaks ( #12256 )
...
Calls to the cache function ended up creating a new texture regardless whether
the texture is already cached.
2022-05-04 20:55:13 +02:00
paradust7
0704ca0550
Make logging cost free when there is no output target ( #12247 )
...
The logging streams now do almost no work when there is no output target for them.
For example, if LL_VERBOSE has no output targets, then `verbosestream << x` will return a StreamProxy with a null target. Any further `<<` operations applied to it will do nothing.
2022-05-04 20:55:01 +02:00
Lars Müller
ae7664597e
Add vector.combine ( #11920 )
2022-05-04 07:44:14 -04:00