Call sound groups directly

https://github.com/SmallJoker/simple_protection/tree/3f34eda

README.md

@@ -18,8 +18,8 @@ Settings documented in [reference][].
 
 ### Requirements:
 
-- Depends: default, tnt
-- Optional depends: nether, sounds
+- Depends: cmer, default, tnt
+- Optional depends: nether, sounds, simple_protection
 
 ### Links:
 

TODO.txt

@@ -2,4 +2,14 @@
 TODO:
 - add version using mobs_redo API
 - add version using cmer API
-- fix vertical position
+- add griefing option
+- add wear to armor when exploding
+- disable attacking if damage disabled
+- make powered versions run faster when chasing
+- fix knockback when chasing
+- fix hit sound when chasing
+- make sneeker stop when within 2 of player
+- use asm_spawneggs for egg
+- add localization support
+- add Spanish translation
+- fix removing single node if protected

changelog.txt

@@ -1,7 +1,17 @@
 
+next
+----
+- uses "sounds" mod
+
+
 v1.1
 ----
 - added sound when hit
+- fixed entity vertical positioning
+- fixed tnt:boom node left after explosion
+- added setting to customize spawn nodes
+- added simple_protection support
+
 
 v1.0
 ----

docs/reference/index.html

@@ -104,6 +104,10 @@
 	<td class="name" nowrap><a href="#sneeker.spawn_mapblock_limit">sneeker.spawn_mapblock_limit</a></td>
 	<td class="summary">Limits the number of entities that can spawn per mapblock (16x16x16).</td>
 	</tr>
+	<tr>
+	<td class="name" nowrap><a href="#sneeker.spawn_nodes">sneeker.spawn_nodes</a></td>
+	<td class="summary">Comma-separated list of nodes on which sneeker can spawn.</td>
+	</tr>
 </table>
 
 <br/>
@@ -473,6 +477,33 @@
 
 
 
+</dd>
+    <dt>
+    <a name = "sneeker.spawn_nodes"></a>
+    <strong>sneeker.spawn_nodes</strong>
+    </dt>
+    <dd>
+    Comma-separated list of nodes on which sneeker can spawn.
+
+    </ul>
+    </ul>
+    </ul>
+    </ul>
+    <h3>Type:</h3>
+    <ul>
+         <i>string</i>
+    </ul>
+    <h3>Default:</h3>
+    <ul>
+         <i>default:dirt_with_dry_grass,default:dry_dirt,default:dry_dirt_with_dry_grass,default:desert_sand,nether:rack</i>
+    </ul>
+    </ul>
+
+
+
+
+
+
 </dd>
 </dl>
 
@@ -481,7 +512,7 @@
 </div> <!-- id="main" -->
 <div id="about">
 <i>generated by <a href="http://github.com/stevedonovan/LDoc">LDoc 1.4.6</a></i>
-<i style="float:right;">Last updated 2021-07-19 17:34:41 </i>
+<i style="float:right;">Last updated 2021-07-20 11:23:32 </i>
 </div> <!-- id="about" -->
 </div> <!-- id="container" -->
 </body>

entity.lua

@@ -1,12 +1,13 @@
 
-local sounds_enabled = core.get_modpath("sounds") ~= nil
 local hit_sound
 
-if sounds_enabled then
+if core.get_modpath("default") then
+	hit_sound = "player_damage"
+elseif core.get_modpath("sounds") then
 	hit_sound = "sounds_entity_hit"
 end
 
-
+--[[
 local function jump(self, pos, direction)
 	local velocity = self.object:get_velocity()
 	if core.registered_nodes[core.get_node(pos).name].climbable then
@@ -51,10 +52,12 @@ local function random_turn(self)
 	end
 end
 
+local walk_speed = 1.5
+
 local def = {
 	hp_max = 20,
 	physical = true,
-	collisionbox = {-0.25, -0.7, -0.25, 0.25, 0.8, 0.25},
+	collisionbox = {-0.25, 0.3, -0.25, 0.25, 1.8, 0.25},
 	visual = "mesh",
 	mesh = "character.b3d",
 	textures = {"sneeker.png"},
@@ -67,29 +70,110 @@ local def = {
 		walk_START = 168,
 		walk_END = 187
 	},
-	walk_speed = 1.5,
+	walk_speed = walk_speed,
 	jump_height = 5,
 	animation_speed = 30,
 	knockback_level = 2
 }
+]]
 
-def.on_activate = function(self, staticdata)
+local spawn_nodes = {}
+if sneeker.spawn_nodes ~= "" then
+	if not sneeker.spawn_nodes:find(",") then
+		table.insert(spawn_nodes, sneeker.spawn_nodes)
+	else
+		for _, node in ipairs(sneeker.spawn_nodes:split(",")) do
+			local node = node:trim()
+			if node ~= "" then
+				table.insert(spawn_nodes, node)
+			end
+		end
+	end
+end
+
+if #spawn_nodes == 0 then
+	sneeker.log("warning", "no spawning nodes set, cannot spawn")
+end
+
+local item_drops = {}
+if core.registered_items["tnt:gunpowder"] then
+	table.insert(item_drops, {"tnt:gunpowder", {min=1, max=2}, chance=0.66})
+end
+
+local def = {
+	name = "sneeker:sneeker",
+	nametag = "Sneeker",
+	stats = {
+		hp = 20,
+		hostile_2 = true,
+		lifetime = sneeker.lifetime,
+		can_jump = 5,
+		can_swim = true,
+		has_knockback = true,
+		sneaky = true,
+	},
+	modes = {
+		idle = {chance=0.3},
+		walk = {chance=0.7, moving_speed=1.5},
+		--chase = {moving_speed=1.5},
+		--death = {},
+	},
+	model = {
+		mesh = "character.b3d",
+		textures = {"sneeker.png"},
+		collisionbox = {-0.25, 0.3, -0.25, 0.25, 1.8, 0.25},
+		rotation = -90,
+		animations = {
+			idle = {start=0, stop=79, speed=30},
+			walk = {start=168, stop=187, speed=30},
+			--chase = {start=168, stop=187, speed=30},
+			--death = {},
+		},
+	},
+	--sounds = {},
+	drops = item_drops,
+	--[[
+	combat = {
+		search_enemy = true,
+	},
+	]]
+	spawning = {
+		abm_nodes = {
+			spawn_on = spawn_nodes,
+		},
+		abm_interval = sneeker.spawn_interval,
+		abm_chance = sneeker.spawn_chance,
+		number = 1,
+		light = {min=sneeker.spawn_minlight, max=sneeker.spawn_maxlight},
+		height_limit = {min=sneeker.spawn_minheight, max=sneeker.spawn_maxheight},
+	},
+}
+
+def.on_activate = function(self, staticdata, dtime_s)
+	--[[
 	self.yaw = 0
 	self.anim = 1
 	self.timer = 0
+	]]
 	self.visualx = 1
+	--[[
 	self.jump_timer = 0
 	self.turn_timer = 0
 	self.turn_speed = 0
+	]]
 	self.powered = false
+	--[[
 	self.knockback = false
 	self.state = math.random(1, 2)
 	self.old_y = self.object:get_pos().y
+	]]
 
+	--[[
 	-- despawning
 	self.lifetime = sneeker.lifetime
 	self.lifetimer = 0
 	self.check_despawn_player_distance = true
+	]]
 
 	local data = core.deserialize(staticdata)
 	if data and type(data) == "table" then
@@ -111,9 +195,9 @@ local function isnan(n)
 end
 
 local function expand(self)
-	if self.chase and self.visualx < 2 then
-		if self.hiss == false then
-			core.sound_play("sneeker_hiss", {object=self.object, gain=1.5, max_hear_distance=2*64})
+	if self.expanding and self.visualx < 2 then
+		if self.hiss == false and sounds then
+			sounds.fuse(1, {object=self.object, gain=1.5, max_hear_distance=2*64})
 		end
 		self.visualx = self.visualx+0.05
 		self.object:set_properties({
@@ -132,13 +216,84 @@ end
 local function explode(self, pos)
 	self.object:remove()
 	sneeker.boom(pos, self.powered)
-	core.sound_play("sneeker_explode", {object=self.object, gain=sneeker.boom_gain, max_hear_distance=2*64})
 end
 
-def.on_step = function(self, dtime)
+--[[
+local function h_collides(pos, collision_info, touching_ground)
+	if not touching_ground or type(collision_info) ~= "table" or #collision_info == 0 then
+		return false
+	end
+
+	local pos_y = math.floor(pos.y)
+	local h_col
+
+	for _, col in ipairs(collision_info) do
+		local npos = col.node_pos
+		if npos and col.type == "node" then
+			-- exclude ground collisions
+			if math.floor(npos.y) > pos_y then
+				h_col = col
+				break
+			end
+		end
+	end
+
+	if not h_col then return false end
+
+	local h_vel = {
+		x = math.floor(h_col.new_velocity.x * 10) / 10,
+		z = math.floor(h_col.new_velocity.z * 10) / 10,
+	}
+
+	return h_vel.x < walk_speed and h_vel.z < walk_speed, h_col.node_pos
+end
+]]
+
+local function chase(self, target)
+	-- FIXME: why does setting mode = "chase" not work?
+	if not self.chase_anim then
+		self.object:set_animation({x=168, y=187}, 30, 0)
+		self.chase_anim = true
+	end
+
+	local pos = self.object:get_pos()
+	local tpos = target:get_pos()
+
+	local vec = {x=tpos.x-pos.x, y=tpos.y-pos.y, z=tpos.z-pos.z}
+	local yaw = math.atan(vec.z/vec.x)+math.pi^2
+	if tpos.x > pos.x then
+		yaw = yaw+math.pi
+	end
+	yaw = yaw-2
+	self.object:set_yaw(yaw)
+	local direction = {x=math.sin(yaw)*-1, y=0, z=math.cos(yaw)}
+
+	-- FIXME: hack
+	local can_set = true
+	for _, c in ipairs({direction.x*2.5, direction.z*2.5}) do
+		if isnan(c) then
+			can_set = false
+			break
+		end
+	end
+
+	if can_set then
+		self.object:set_velocity({x=direction.x*2.5, y=self.object:get_velocity().y, z=direction.z*2.5})
+	end
+end
+
+local function end_chase(self)
+	self.chasing = nil
+	self.chase_anim = false
+	self.mode = "idle"
+	self.expanding = false
+end
+
+def.on_step = function(self, dtime, moveresult)
+	--[[
 	-- update lifetime timer
 	-- FIXME: this is longer than realtime
-	self.lifetimer = self.lifetimer + dtime
+	self.lifetimer = self.lifetimer + dtime_s
 	if self.lifetimer >= self.lifetime then
 		-- TODO: should have a death animation
 		self.object:remove()
@@ -151,9 +306,11 @@ def.on_step = function(self, dtime)
 
 	local ANIM_STAND = 1
 	local ANIM_WALK  = 2
+	]]
 
 	local pos = self.object:get_pos()
 
+	--[[
 	if sneeker.despawn_player_far then
 		-- run check about once per 60 seconds
 		local interval_reached = math.floor(self.lifetimer % 60) == 0
@@ -180,6 +337,13 @@ def.on_step = function(self, dtime)
 		end
 	end
 
+	if self.chase or self.state == "chase" or self.state == "walk" then
+		local collided, npos = h_collides(pos, moveresult.collisions, moveresult.touching_ground)
+		if collided then
+			jump(self, npos, self.direction)
+		end
+	end
+
 	local yaw = self.object:get_yaw()
 	local inside = core.get_objects_inside_radius(pos, 10)
 	local walk_speed = self.walk_speed
@@ -207,9 +371,22 @@ def.on_step = function(self, dtime)
 		self.yaw = self.yaw-self.turn_speed
 		self.object:set_yaw(self.yaw)
 	end
+	]]
 
 	expand(self)
 
+	local players_within_10 = {}
+	for _, object in ipairs(core.get_objects_inside_radius(pos, 10)) do
+		if object:is_player() then
+			table.insert(players_within_10, object)
+		end
+	end
+
+	if not self.chasing then
+		self.chasing = players_within_10[1]
+	end
+
+	--[[
 	self.chase = false
 
 	for  _, object in ipairs(inside) do
@@ -262,14 +439,50 @@ def.on_step = function(self, dtime)
 				self.turn_speed = 0.05*math.random()
 			end
 		end
+	end
+	]]
 
-		-- Jump
-		if self.jump_timer > 0.2 then
-			jump(self, pos, self.direction)
+	if self.chasing then
+		if self.chasing:get_hp() > 0 then
+			self.mode = "chase"
+
+			local within_2 = false
+			for _, object in ipairs(core.get_objects_inside_radius(pos, 2)) do
+				if object == self.chasing then
+					within_2 = true
+					break
 				end
 			end
 
-	if self.state == "chase" then
+			if within_2 then
+				if self.visualx >= 2 then
+					explode(self, pos)
+					self.chasing = nil
+					return true
+				end
+				self.expanding = true
+			else
+				self.expanding = false
+			end
+
+			local within_10 = false
+			for _, object in ipairs(players_within_10) do
+				if object == self.chasing then
+					within_10 = true
+					break
+				end
+			end
+
+			if within_10 then
+				-- follow player
+				chase(self, self.chasing)
+				return true
+			end
+		end
+
+		end_chase(self)
+
+		--[[
 		if self.anim ~= ANIM_WALK then
 			self.object:set_animation({x=animation.walk_START, y=animation.walk_END}, anim_speed, 0)
 			self.anim = ANIM_WALK
@@ -291,7 +504,9 @@ def.on_step = function(self, dtime)
 				end
 			end
 		end
+		]]
 
+		--[[
 		if #inside ~= 0 then
 			for  _, object in ipairs(inside) do
 				if object:is_player() and object:get_hp() ~= 0 then
@@ -333,18 +548,17 @@ def.on_step = function(self, dtime)
 					if can_set then
 						self.object:set_velocity({x=direction.x*2.5, y=velocity.y, z=direction.z*2.5})
 					end
-
-					-- Jump
-					if self.jump_timer > 0.2 then
-						jump(self, pos, direction)
-					end
 				end
 			end
 		else
 			self.state = "stand"
 		end
+		]]
+	elseif self.mode == "chase" then
+		self.mode = "idle"
 	end
 
+	--[[
 	-- Swim
 	local node = core.get_node(pos)
 	if core.get_item_group(node.name, "water") ~= 0 then
@@ -360,8 +574,10 @@ def.on_step = function(self, dtime)
 	end
 
 	return true
+	]]
 end
 
+--[[
 def.on_punch = function(self, puncher, time_from_last_punch, tool_capabilities, dir)
 	if hit_sound then
 		core.sound_play(hit_sound, {object=self.object}, parameters, true)
@@ -387,6 +603,7 @@ def.on_punch = function(self, puncher, time_from_last_punch, tool_capabilities,
 		local obj = core.add_item(p, {name="tnt:gunpowder", count=math.random(0, 2)})
 	end
 end
+]]
 
 def.get_staticdata = function(self)
 	return core.serialize({
@@ -394,7 +611,11 @@ def.get_staticdata = function(self)
 	})
 end
 
+--[[
 core.register_entity("sneeker:sneeker", def)
+]]
+
+cmer.register_mob(def)
 
 core.register_craftitem("sneeker:spawnegg", {
 	description = "Sneeker Spawn Egg",

init.lua

@@ -28,7 +28,6 @@ end
 local scripts = {
 	"settings",
 	"tnt_function",
-	"spawn",
 	"entity",
 }
 

mod.conf

@@ -1,7 +1,9 @@
 name = sneeker
 title = Sneeker
 description = An explosive nuisance.
-version = 1.0
-author = Rui
-depends = default, tnt
-optional_depends = nether, sounds
+license = MIT
+version = 1.1
+author = Rui, Jordan Irwin (AntumDeluge)
+min_minetest_version = 5.0
+depends = cmer, default, tnt
+optional_depends = nether, sounds, simple_protection

settings.lua

@@ -106,3 +106,11 @@ sneeker.spawn_maxheight = tonumber(core.settings:get("sneeker.spawn_maxheight")
 --  @settype int
 --  @default 1
 sneeker.spawn_mapblock_limit = tonumber(core.settings:get("sneeker.spawn_mapblock_limit") or 1)
+
+--- Comma-separated list of nodes on which sneeker can spawn.
+--
+--  @setting sneeker.spawn_nodes
+--  @settype string
+--  @default default:dirt_with_dry_grass,default:dry_dirt,default:dry_dirt_with_dry_grass,default:desert_sand,nether:rack
+sneeker.spawn_nodes = core.settings:get("sneeker.spawn_nodes") or "default:dirt_with_dry_grass,default:dry_dirt,default:dry_dirt_with_dry_grass,default:desert_sand,nether:rack"
+sneeker.spawn_nodes = sneeker.spawn_nodes:trim()

settingtypes.txt

@@ -50,3 +50,6 @@ sneeker.spawn_maxheight (Sneeker max spawn height) int 31000
 
 # Limits the number of entities that can spawn per mapblock (16x16x16).
 sneeker.spawn_mapblock_limit (Sneeker spawn limit) int 1
+
+# Comma-separated list of nodes on which sneeker can spawn.
+sneeker.spawn_nodes (Sneeker spawn nodes) string default:dirt_with_dry_grass,default:dry_dirt,default:dry_dirt_with_dry_grass,default:desert_sand,nether:rack

spawn.lua

@@ -1,70 +0,0 @@
-
-local spawn_nodes = {
-	"default:dirt_with_dry_grass",
-	"default:dry_dirt",
-	"default:dry_dirt_with_dry_grass",
-	"default:desert_sand",
-}
-
-if core.global_exists("nether") then
-	table.insert(spawn_nodes, "nether:rack")
-end
-
-for _, node_name in ipairs(spawn_nodes) do
-	if not core.registered_nodes[node_name] then
-		sneeker.log("warning", "Invalid node for spawn: " .. node_name)
-	end
-end
-
-
-core.register_abm({
-	nodenames = spawn_nodes,
-	neighbors = {"air"},
-	interval = sneeker.spawn_interval,
-	chance = sneeker.spawn_chance,
-	action = function(pos, node, aoc, aocw)
-		if aoc >= sneeker.spawn_mapblock_limit then return end
-
-		-- check above target node
-		pos.y = pos.y+1
-
-		local pos_string = tostring(math.floor(pos.x))
-			.. "," .. tostring(math.floor(pos.y))
-			.. "," .. tostring(math.floor(pos.z))
-
-		if sneeker.spawn_require_player_nearby then
-			local player_nearby = false
-			for _, entity in ipairs(core.get_objects_inside_radius(pos, sneeker.spawn_player_radius)) do
-				if entity:is_player() then
-					player_nearby = true
-					break
-				end
-			end
-
-			if not player_nearby then return end
-		end
-
-		if pos.y > sneeker.spawn_maxheight or pos.y < sneeker.spawn_minheight then
-			return
-		end
-
-		-- needs two vertical air nodes to spawn
-		for _, node_pos in ipairs({pos, {x=pos.x, y=pos.y+1, z=pos.z}}) do
-			if core.get_node(node_pos).name ~= "air" then
-				return
-			end
-		end
-
-		local llevel = core.get_node_light(pos)
-		if not llevel or llevel > sneeker.spawn_maxlight or llevel < sneeker.spawn_minlight then
-			return
-		end
-
-		local spawned = core.add_entity(pos, "sneeker:sneeker")
-		if not spawned then
-			sneeker.log("warning", "Failed to spawn at: " .. pos_string)
-		else
-			sneeker.log("debug", "Spawned at: " .. pos_string)
-		end
-	end
-})

tnt_function.lua

@@ -164,8 +164,21 @@ local function add_drop(drops, item)
 	end
 end
 
+local function is_protected(pos, name) return core.is_protected(pos, name) end
+if core.global_exists("simple_protection") and simple_protection.can_access then
+	is_protected = function(pos, name)
+		local s_protect_name = name
+		-- simple_protection ignores names with empty strings
+		if s_protect_name == "" then
+			s_protect_name = " "
+		end
+
+		return core.is_protected(pos, name) or not simple_protection.can_access(pos, s_protect_name)
+	end
+end
+
 local function destroy(drops, pos, cid)
-	if core.is_protected(pos, "") then
+	if is_protected(pos, "") then
 		return
 	end
 	local def = cid_data[cid]
@@ -294,11 +307,14 @@ function sneeker.boom(pos, large)
 	if large then
 		radius = large_radius
 	end
-	core.sound_play("sneeker_explode", {pos=pos, gain=1.5, max_hear_distance=2*64})
+	if sounds then
+		sounds.explosion(1, {pos=pos, gain=sneeker.boom_gain, max_hear_distance=2*64})
+	end
 	core.set_node(pos, {name="tnt:boom"})
 	core.get_node_timer(pos):start(0.5)
 	local drops = explode(pos, radius)
 	entity_physics(pos, radius)
 	eject_drops(drops, pos, radius)
 	add_effects(pos, radius)
+	core.remove_node(pos)
 end