Commit Graph

121 Commits

Author SHA1 Message Date
teknomunk
aabd80d54b Change MineClone 2 to VoxeLibre 2024-05-07 11:38:00 +00:00
𝕵𝖔𝖍𝖆𝖓𝖓𝖊𝖘 𝕱𝖗𝖎𝖙𝖟
a620d24ec8 Fix a number of crashes involving unknown nodes, also fix fishbuckets on_place (#3914)
Fixes: #3913 #3915

~~You can reproduce the crash by placing a fish bucket on top snow above an unknown node.

I also noticed that the code always uses pointed_thing.above so I fixed that and also added a function to mcl_utils to figure out where a node should be placed (either above or below). Looks like the rest of the code could also use improvement but at least it does not crash now.~~

Cora fixed a bunch of related crashes in Mineclona so I am replacing my commit and cherry picking all her commits here.
https://codeberg.org/mineclonia/mineclonia/pulls/549

Here is the list of fixes from that PR:
- Crash when placing snow layer on unknown nodes
- Crash when snow layers on unknown nodes are flooded
- Crash when placing fishbucket on snow on top of unknown nodes
- Crash when placing chorus flower and stem on unknown
- Crash when placing mob spawners on unknown
- The fishbucket on place to actually replace buildable_to

Co-authored-by: cora <coradelamouche@gmx.ch>
Reviewed-on: https://git.minetest.land/MineClone2/MineClone2/pulls/3914
Reviewed-by: ancientmarinerdev <ancientmariner_dev@proton.me>
Co-authored-by: 𝕵𝖔𝖍𝖆𝖓𝖓𝖊𝖘 𝕱𝖗𝖎𝖙𝖟 <mrrar@noreply.git.minetest.land>
Co-committed-by: 𝕵𝖔𝖍𝖆𝖓𝖓𝖊𝖘 𝕱𝖗𝖎𝖙𝖟 <mrrar@noreply.git.minetest.land>
2023-09-29 18:47:07 +00:00
Sab Pyrope
5b4a79a26d Update russian translation 2023-08-31 14:16:42 +08:00
PrairieWind
d467b80491 Fix waterlogged mangrove roots leaving water in the nether 2023-05-16 19:35:56 +00:00
FossFanatic
998983445b Rename Bucket Textures (#3708)
This pull request renames buckets so that they use the `mcl_` naming convention.

I originally was going to do some renaming on a bigger scope, but decided against it for now.

Reviewed-on: https://git.minetest.land/MineClone2/MineClone2/pulls/3708
Reviewed-by: ancientmarinerdev <ancientmariner_dev@proton.me>
Co-authored-by: FossFanatic <fossfanatic@noreply.git.minetest.land>
Co-committed-by: FossFanatic <fossfanatic@noreply.git.minetest.land>
2023-05-14 11:41:39 +00:00
3raven
9518d47662 (french) translation enhancements (#3643)
- Add missing translation
- Fix broken translations
- Fix unacurate description
- Correct/improve/change for cohesion french translation

Translations templates have been updated,other translations must be updated.

<!--
Please follow our contributing guidelines first:
https://git.minetest.land/MineClone2/MineClone2/src/branch/master/CONTRIBUTING.md#how-you-can-help-as-a-programmer

By submitting this pull request, you agree to follow our Code of Conduct:
https://git.minetest.land/MineClone2/MineClone2/src/branch/master/CODE_OF_CONDUCT.md
-->

Tell us about your pull request! Reference related issues, if necessary

### Testing
Tell us how to test your changes!

Co-authored-by: 3raven <elise_declerck@laposte.net>
Reviewed-on: https://git.minetest.land/MineClone2/MineClone2/pulls/3643
Reviewed-by: AFCMS <afcm.contact@gmail.com>
Co-authored-by: 3raven <3raven@noreply.git.minetest.land>
Co-committed-by: 3raven <3raven@noreply.git.minetest.land>
2023-05-11 22:39:49 +00:00
syl
1d981876d9 Fix syntax errors in French 2023-03-14 11:55:07 +01:00
syl
96b2f6a01d Improve French translation 2023-03-10 22:48:46 +01:00
anarquimico
6bdc0f032f Fixed for river_water_logged_roots 2023-03-01 19:22:27 -07:00
anarquimico
0aa3c52263 Make it work with river water 2023-03-01 19:22:27 -07:00
anarquimico
f4c26fb578 Change the mangrove roots to a water logged roots after using a bucket with water on it 2023-03-01 19:22:27 -07:00
FossFanatic
d3253ecf4f Change small part of buckets code 2023-02-18 08:25:47 +00:00
Michieal
660c85dddc Changed mcl_buckets' image use to be named properly. This fixes issue #3455 2023-02-15 14:52:00 +00:00
anarquimico
ed8c3e7d26 Second batch of ITEMS translated 2023-02-07 16:39:22 +00:00
Michieal
6265148727 Move textures all into one centralized directory. 2023-01-30 22:55:53 -05:00
Johannes Fritz
6e6c11cde2 Fix undeclared global variable in mcl_buckets 2023-01-16 12:56:59 -06:00
Riu Sakura
3faa930bdc Added missing translations.
In addition, the translation of "Grass Block" has been corrected to a better phrase.
2022-12-21 10:24:26 +09:00
Riu Sakura
2b61231f82 add japanese translation 2022-12-19 15:33:31 +09:00
cora
927eff691c Fix node on_rightclick with fishbucket 2022-11-27 04:02:34 +01:00
cora
efdd22d69f Fix fishbuckets placing water in the nether 2022-11-27 00:17:13 +01:00
cora
f14bfdc0cd Clear item meta when turning fishbucket to empty bucket
before it simply set a different itemstring, now it creates a
whole new itemstack
2022-11-26 22:18:46 +01:00
cora
66322a873b Fix infinite fishbucket placement in survival/creative 2022-11-26 22:18:46 +01:00
cora
e134cc5e65 make it possible to place fishbucket in flowing riverwater 2022-11-26 22:18:46 +01:00
cora
1fcedd1375 Fix fishbucket _on_dispense 2022-11-26 22:18:46 +01:00
cora
bb73e5f1cd Make it possible to pick up fish with river water bucket 2022-11-26 22:18:46 +01:00
cora
ebf4678e54 mcl_buckets whitespace fixes 2022-11-26 22:18:46 +01:00
cora
b4971b298d Move fish bucket code to separate file 2022-11-26 22:18:46 +01:00
cora
99db678a44 Fish buckets set properties from bucket item meta 2022-11-26 22:18:46 +01:00
cora
dd58bed5d1 refactor fish bucket code to not use bucket api
it was clearly not made for this
2022-11-26 22:18:46 +01:00
cora
53c1ed9fbf Merge pull request 'Axolotl' (#2870) from TheOnlyJoeEnderman/MineClone2:Axolotl into master
Reviewed-on: https://git.minetest.land/MineClone2/MineClone2/pulls/2870
Reviewed-by: cora <cora@noreply.git.minetest.land>
2022-11-23 03:18:36 +00:00
TheOnlyJoeEnderman
3110f97868 Move axolotl_bucket to buckets mod 2022-11-07 08:19:44 +00:00
TheOnlyJoeEnderman
7e3d5f3553 add axolotl to bucket translation template 2022-11-04 01:58:04 +00:00
Johannes Fritz
8faa6aa9eb Fix buckets on Android 2022-11-01 03:46:45 +00:00
TheOnlyJoeEnderman
0624d9d169 Change spaces to tabs on line 127 2022-10-29 04:29:13 +00:00
TheOnlyJoeEnderman
d324197609 Fix duplicate/unnecessary "fish" in several names 2022-10-26 21:43:41 +00:00
TheOnlyJoeEnderman
f352e99eb6 add axolotl to list of bucketable fish 2022-10-21 00:44:18 +00:00
3raven
b15575469a Add translation 2022-08-22 22:15:37 +00:00
PrairieAstronomer
64f810ac76 Removed some unnessary code 2022-07-30 12:40:04 -06:00
PrairieAstronomer
a153e5bc33 Fixed Place Water in the Nether with Fish Buckets. 2022-07-30 12:21:16 -06:00
cora
3a7022ab66 Clean up buckets and cauldrons a little bit 2022-06-21 13:53:08 +02:00
cora
685cba6821 Allow placing lava into cauldrons 2022-06-21 13:44:52 +02:00
cora
7a8d20e124 take lava from cauldron with bucket 2022-06-21 13:08:20 +02:00
Elias Fleckenstein
f6a40ffb78
Run tools/strip_trailing_whitespace.sh 2022-05-26 07:29:28 +02:00
Emojigit
af8681c143 mcl_buckets 2022-02-23 23:58:05 +01:00
kabou
af132cc523 Reinstate nil check in on_place_bucket.
* Oops, nil checks on registered_node[name] were erroneously optimized
  away, risking crashes.  Reinstate those checks.
2022-02-21 18:00:56 +01:00
kabou
e54502edd6 Add more local aliases for minetest.* namespace functions
* Add locals for
  - minetest.is_creative_enabled
  - minetest.is_protected
  - minetest.record_protection_violation
2022-02-20 20:24:55 +01:00
kabou
639bf936c5 Use alias for minetest.* namespace function call.
* Fix one missed minetest.get_node use in earlier commit.
2022-02-20 19:52:05 +01:00
kabou
d2261426c3 Remove redundant variables in on_place_bucket.
The function on_place_bucket defined a couple of variables that were
used only once or in a redundant check.  After removal of the redundant
check in a previous commit, all use-once variables can now be substituted
with their assignment expressions.
2022-02-20 18:46:23 +01:00
kabou
88ce1e3662 Remove redundant logic.
The function on_place_bucket contains the following logic:
  if not a and not b then return x end
  if a then
    foo(a)
  elseif b then
    foo(b)
  else
    return x
  end

The "if not a and not b then .." is removed because the case is handled
by the else case later on.  This will allow some further simplifications.
2022-02-20 18:46:23 +01:00
kabou
b3aed9d6b8 Use proper get_item_group accessor.
Instead of directly accessing the group table in node definitions, use
the proper minetest.get_item_group accessor to test for "cauldron"
group.
Also adds local alias get_item_group for the global minetest call.
2022-02-20 18:46:23 +01:00