Mirrorlandia_minetest/MineClone2
1
0
Fork 0
mirror of https://git.minetest.land/MineClone2/MineClone2.git synced 2024-11-24 20:03:45 +01:00
Code Issues Packages Projects Releases Wiki Activity
12,361 Commits 108 Branches 83 Tags 166 MiB
5bce56cdd6
Commit Graph

10695 Commits

Author SHA1 Message Date
teknomunk
bb9ed4498b Address review comments 2024-06-26 06:52:26 -05:00
teknomunk
94981d9c09 Add return for get_staticdata 2024-06-26 12:23:30 +02:00
teknomunk
7ae05d9c06 Add persistence to XP orbs, cleanup xp_to_size 2024-06-26 12:23:30 +02:00
teknomunk
177e8f4b9d Code cleanup 2024-06-26 12:23:30 +02:00
the-real-herowl
8bbceddbc2 Updated release credits and set version for hotfix v0.87.2 2024-06-24 03:28:19 +02:00
the-real-herowl
6e70c760d6 Fix some formspecs on mobile (#4456) 
This should allow renaming items on the anvil when using mobile. This also may improve mobile craftguide experience.

Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4456
Co-authored-by: the-real-herowl <wiktor_t-i@proton.me>
Co-committed-by: the-real-herowl <wiktor_t-i@proton.me>
 2024-06-24 03:26:02 +02:00
teknomunk
3928e12634 Fix two more crashes, stray space 2024-06-24 03:06:26 +02:00
teknomunk
304550d90c Fix parameter name 2024-06-24 03:06:26 +02:00
teknomunk
0a2336ad82 Handle conversion of mobs that were incorrectly converted 2024-06-24 03:06:26 +02:00
teknomunk
75a767a0ab Mob spawner conversion 2024-06-24 03:06:26 +02:00
teknomunk
7e0afd7e21 Remove debug logging 2024-06-24 03:06:26 +02:00
teknomunk
15fa925aae More fields to strip 2024-06-24 03:06:26 +02:00
teknomunk
4935f5fdda Add debug logging 2024-06-24 03:06:26 +02:00
teknomunk
41032ec999 Use correct variable name 2024-06-24 03:06:26 +02:00
teknomunk
d64ee18f75 Strip some fields from the mob's staticdata on conversion 2024-06-24 03:06:26 +02:00
teknomunk
1942384fe5 Move object remove after position check 2024-06-24 03:06:26 +02:00
teknomunk
9b50dd6565 Update to use new_object instead of obj 2024-06-24 03:06:26 +02:00
teknomunk
a88951ac6a More safety checks 2024-06-24 03:06:26 +02:00
teknomunk
bc343769ee Add guard to prevent crash when converting old mobs and the minetest fails to create the new entity 2024-06-24 03:06:26 +02:00
seventeenthShulker
8aa65f85f2 Fix extra 'Stair' in Polished Blackstone Brick nodes (#4450) 
Some of the longest block names were erroneous. Farewell, Polished Blackstone Brick Stair Stairs and Polished Blackstone Brick Stair Slab.

Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4450
Reviewed-by: the-real-herowl <the-real-herowl@noreply.git.minetest.land>
Co-authored-by: seventeenthShulker <c545d588-7ff2-49b9-b537-0b3f769083ad@anonaddy.me>
Co-committed-by: seventeenthShulker <c545d588-7ff2-49b9-b537-0b3f769083ad@anonaddy.me>
 2024-06-23 23:40:36 +02:00
qoheniac
e27e70a91b fix wrong name for diorite stairs (#4359) 
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4359
Reviewed-by: teknomunk <teknomunk@protonmail.com>
Co-authored-by: qoheniac <qoheniac@noreply.git.minetest.land>
Co-committed-by: qoheniac <qoheniac@noreply.git.minetest.land>
 2024-06-23 23:39:09 +02:00
JoseDouglas26
744b47088b Fixes flint and steel adding wear when not setting node on fire (#4368) 
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4368
Reviewed-by: teknomunk <teknomunk@protonmail.com>
Co-authored-by: JoseDouglas26 <josedouglas20002014@gmail.com>
Co-committed-by: JoseDouglas26 <josedouglas20002014@gmail.com>
 2024-06-16 18:33:19 +02:00
the-real-herowl
72435933e4 Add defensive check (#4437) 
This fixes #4436 and possible other unnoticed crashes by adding a defensive check.

Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4437
Reviewed-by: Mikita Wiśniewski <rudzik8@protonmail.com>
Co-authored-by: the-real-herowl <wiktor_t-i@proton.me>
Co-committed-by: the-real-herowl <wiktor_t-i@proton.me>
 2024-06-15 03:51:03 +02:00
the-real-herowl
35e14dd415 Potion conversion fix (#4426) 
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4426
Reviewed-by: Mikita Wiśniewski <rudzik8@protonmail.com>
Co-authored-by: the-real-herowl <wiktor_t-i@proton.me>
Co-committed-by: the-real-herowl <wiktor_t-i@proton.me>
 2024-06-13 13:22:14 +02:00
the-real-herowl
173f8a0bca Effect loading fixes (#4425) 
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4425
Reviewed-by: Mikita Wiśniewski <rudzik8@protonmail.com>
Co-authored-by: the-real-herowl <wiktor_t-i@proton.me>
Co-committed-by: the-real-herowl <wiktor_t-i@proton.me>
 2024-06-13 13:21:36 +02:00
teknomunk
1f32b47208 Fix crash while fighting whither (#4392) 
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4392
Reviewed-by: the-real-herowl <the-real-herowl@noreply.git.minetest.land>
Co-authored-by: teknomunk <teknomunk@protonmail.com>
Co-committed-by: teknomunk <teknomunk@protonmail.com>
 2024-06-12 14:18:03 +02:00
WillConker
fd4e1484af Fix crash on high levels of frost walker (#4423) 
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4423
Reviewed-by: the-real-herowl <the-real-herowl@noreply.git.minetest.land>
Co-authored-by: WillConker <willconker@noreply.git.minetest.land>
Co-committed-by: WillConker <willconker@noreply.git.minetest.land>
 2024-06-11 19:17:12 +02:00
teknomunk
1b0deae026 Fix crash when bonemealing sweet berry bushes (#4419) 
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4419
Reviewed-by: Mikita Wiśniewski <rudzik8@protonmail.com>
Co-authored-by: teknomunk <teknomunk@protonmail.com>
Co-committed-by: teknomunk <teknomunk@protonmail.com>
 2024-06-11 18:47:18 +02:00
teknomunk
313c1f558b Make all hollow logs breakable (#4418) 
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4418
Reviewed-by: the-real-herowl <the-real-herowl@noreply.git.minetest.land>
Co-authored-by: teknomunk <teknomunk@protonmail.com>
Co-committed-by: teknomunk <teknomunk@protonmail.com>
 2024-06-11 18:43:33 +02:00
teknomunk
5cafa97dd1 Fix formspec code that reads strength button field (#4385) 
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4385
Reviewed-by: the-real-herowl <the-real-herowl@noreply.git.minetest.land>
Co-authored-by: teknomunk <teknomunk@protonmail.com>
Co-committed-by: teknomunk <teknomunk@protonmail.com>
 2024-06-11 18:40:44 +02:00
teknomunk
ddab68b87c Add instructions on how to eat to basic controls help entry (#4420) 
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4420
Reviewed-by: ancientmarinerdev <ancientmariner_dev@proton.me>
Co-authored-by: teknomunk <teknomunk@protonmail.com>
Co-committed-by: teknomunk <teknomunk@protonmail.com>
 2024-06-10 19:44:30 +00:00
JoseDouglas26
2dafbae64b Hotfix for brewing stands rotation (#4371) 
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4371
Reviewed-by: teknomunk <teknomunk@protonmail.com>
Co-authored-by: JoseDouglas26 <josedouglas20002014@gmail.com>
Co-committed-by: JoseDouglas26 <josedouglas20002014@gmail.com>
 2024-06-07 06:10:52 +00:00
the-real-herowl
21c182fc0e Fixed creative.lua invalidating iterator in loop (#4354) 
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4354
Co-authored-by: the-real-herowl <wiktor_t-i@proton.me>
Co-committed-by: the-real-herowl <wiktor_t-i@proton.me>
 2024-06-02 00:33:29 +00:00
teknomunk
ca033d0e8d Correctly refresh enchantment tool capabilities in mcl_potions haste/fatigue effects (#4355) 
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4355
Reviewed-by: the-real-herowl <the-real-herowl@noreply.git.minetest.land>
Co-authored-by: teknomunk <teknomunk@protonmail.com>
Co-committed-by: teknomunk <teknomunk@protonmail.com>
 2024-06-01 23:25:42 +00:00
teknomunk
beccbacc73 Fix Stalker texture generation (#4343) 
This fixes stalker texture generation when the stalker is standing on a node that uses a texture using a texture modifier.

Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4343
Reviewed-by: the-real-herowl <the-real-herowl@noreply.git.minetest.land>
Co-authored-by: teknomunk <teknomunk@protonmail.com>
Co-committed-by: teknomunk <teknomunk@protonmail.com>
 2024-06-01 20:23:38 +00:00
teknomunk
ecf12b85cc Fix undefined global warning for variable distance in spawning code (#4348) 
Fixes the warning about an undeclared global that occurs the first time a mob attempts to spawn.

Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4348
Reviewed-by: the-real-herowl <the-real-herowl@noreply.git.minetest.land>
Co-authored-by: teknomunk <teknomunk@protonmail.com>
Co-committed-by: teknomunk <teknomunk@protonmail.com>
 2024-05-31 09:54:59 +00:00
the-real-herowl
f53bedc131 Merge pull request 'Fix beacon crash' (#4342) from teknomunk/MineClone2:fix-beacon-crash into master 
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4342
Reviewed-by: the-real-herowl <the-real-herowl@noreply.git.minetest.land>
 2024-05-30 11:19:19 +00:00
the-real-herowl
3e6ec9cf10 Fixed eye of ender crash (#4344) 
This makes sure every loaded eye of ender gets its `_luck` parameter set.

Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4344
 2024-05-30 11:17:19 +00:00
teknomunk
6c8771485c Fix variable name 2024-05-30 10:51:45 +00:00
teknomunk
f621e3c1de Fix up formspecs on pre-0.87.0 beacons, fix typo 2024-05-30 10:51:45 +00:00
teknomunk
7d0f49a218 Fix typo 2024-05-30 10:51:45 +00:00
teknomunk
468c2bc68f Change to conversion table 2024-05-30 10:51:45 +00:00
teknomunk
2fc3d92550 Convert 'strenght' to 'strength' in beacons and guard against no effect string metadata set, fix whitespace in mcl_beacons/init.lua 2024-05-30 10:51:45 +00:00
teknomunk
95228500a9 Don't crash when name == nil 2024-05-30 10:51:45 +00:00
teknomunk
c7e43e31d4 Convert crash to a warning 2024-05-30 10:51:45 +00:00
JoseDouglas26
067ad7b78b Change stack size for snowballs and eggs (#4312) 
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4312
Reviewed-by: the-real-herowl <the-real-herowl@noreply.git.minetest.land>
Co-authored-by: JoseDouglas26 <josedouglas20002014@gmail.com>
Co-committed-by: JoseDouglas26 <josedouglas20002014@gmail.com>
 2024-05-30 08:31:15 +00:00
teknomunk
add9cbe3bc Fix mob spawner crash (#4337) 
This fixes #4336 crash at login about mcl_mobspawners. Also adds an API call, `mcl_mobs.register_conversion` for converting one mob into another and updates rovers and stalkers to use this API call.

Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4337
Reviewed-by: the-real-herowl <the-real-herowl@noreply.git.minetest.land>
Co-authored-by: teknomunk <teknomunk@protonmail.com>
Co-committed-by: teknomunk <teknomunk@protonmail.com>
 2024-05-30 08:29:12 +00:00
teknomunk
c4f4e7b6fc Fix crash that occurs when lingering or splash potions are used from a dispenser (#4335) 
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4335
Reviewed-by: the-real-herowl <the-real-herowl@noreply.git.minetest.land>
Co-authored-by: teknomunk <teknomunk@protonmail.com>
Co-committed-by: teknomunk <teknomunk@protonmail.com>
 2024-05-30 08:02:59 +00:00
the-real-herowl
dfddea76fb Updated release credits and set version for v0.87 2024-05-26 18:30:19 +02:00
the-real-herowl
da491b8505 Documented a returned table (effect data) (#4330) 
Updated documentation, follow-up to #4130

Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4330
Co-authored-by: the-real-herowl <wiktor_t-i@proton.me>
Co-committed-by: the-real-herowl <wiktor_t-i@proton.me>
 2024-05-26 16:29:27 +00:00
the-real-herowl
cae554bc2b Defensive checks (#4328) 
Fixes rare crashes related to some effects

Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4328
Co-authored-by: the-real-herowl <wiktor_t-i@proton.me>
Co-committed-by: the-real-herowl <wiktor_t-i@proton.me>
 2024-05-26 15:32:41 +00:00
teknomunk
8feecf2492 Fix crashes with raids and bad omen effect (#4326) 
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4326
Reviewed-by: the-real-herowl <the-real-herowl@noreply.git.minetest.land>
Co-authored-by: teknomunk <teknomunk@protonmail.com>
Co-committed-by: teknomunk <teknomunk@protonmail.com>
 2024-05-26 15:21:43 +00:00
Mikita Wiśniewski
68e5c19df4 Add new supported_node_facedir group and apply it to item frames (#4291) 
This change should fix item frames not placing on chests and similar blocks

Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4291
Reviewed-by: the-real-herowl <the-real-herowl@noreply.git.minetest.land>
Co-authored-by: Mikita Wiśniewski <rudzik8@protonmail.com>
Co-committed-by: Mikita Wiśniewski <rudzik8@protonmail.com>
 2024-05-26 15:21:14 +00:00
syl
d086bc5176 Mangrove: Missing upper case (#4324) 
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4324
Reviewed-by: the-real-herowl <the-real-herowl@noreply.git.minetest.land>
Co-authored-by: syl <syl@gresille.org>
Co-committed-by: syl <syl@gresille.org>
 2024-05-25 14:42:50 +00:00
the-real-herowl
2bd24120e9 Stalker texture building fix (#4322) 
Added a defensive check for stalker texture building.

Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4322
 2024-05-25 11:57:05 +00:00
syl
4d7060cddd French translation for potions (#4321) 
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4321
Reviewed-by: the-real-herowl <the-real-herowl@noreply.git.minetest.land>
Co-authored-by: syl <syl@gresille.org>
Co-committed-by: syl <syl@gresille.org>
 2024-05-25 11:18:37 +00:00
Nicu
f119259e67 Updated the sleeping formspec for a better look (#4319) 
This PR deals with the UI side of #3645 - no logic was changed to prevent the spam related to the `zzZ` button.

The chatbox now only shows in multiplayer, where it belongs. The buttons have also been resized and moved into positions that make them look nicer.

Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4319
Reviewed-by: the-real-herowl <the-real-herowl@noreply.git.minetest.land>
Co-authored-by: Nicu <kneekoo@noreply.git.minetest.land>
Co-committed-by: Nicu <kneekoo@noreply.git.minetest.land>
 2024-05-24 20:35:13 +00:00
teknomunk
0a14a74860 Fix crash when converting endermen to rovers (#4318) 
Fixes a crash that occurs when automatically converting endermen to rovers.

Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4318
Reviewed-by: the-real-herowl <the-real-herowl@noreply.git.minetest.land>
Co-authored-by: teknomunk <teknomunk@protonmail.com>
Co-committed-by: teknomunk <teknomunk@protonmail.com>
 2024-05-24 10:32:19 +00:00
the-real-herowl
cb4396d424 Fix stonecutter warnings (#4315) 
This fixes faulty fallthrough mechanisms attempting to register the same recipe more than once in some cases. This fixes the warning spam when entering a world, while keeping the warnings for mods that misuse the Stonecutter API.

Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4315
Co-authored-by: the-real-herowl <wiktor_t-i@proton.me>
Co-committed-by: the-real-herowl <wiktor_t-i@proton.me>
 2024-05-24 10:31:27 +00:00
the-real-herowl
a499d292f8 Finish renames (#4314) 
Fix crash caused by unfinished renaming in #4282

Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4314
Co-authored-by: the-real-herowl <wiktor_t-i@proton.me>
Co-committed-by: the-real-herowl <wiktor_t-i@proton.me>
 2024-05-22 19:18:10 +00:00
the-real-herowl
07fac026dd Added a darkness potion recipe 2024-05-22 21:03:43 +02:00
the-real-herowl
0c57469c6b Updated Polish translation 2024-05-22 21:03:43 +02:00
the-real-herowl
018814c362 Added a few mobitems 
* one droppable from strays
* the rest will get their mobs in a later update
* added alternative ways to get the items
* added recipes for potions that use these items
 2024-05-22 21:03:43 +02:00
the-real-herowl
496360a1c4 Updated Polish translation 2024-05-22 21:03:43 +02:00
the-real-herowl
191dd1b950 Update template.txt 2024-05-22 21:03:43 +02:00
the-real-herowl
551bc99517 Improved compat alias visual 2024-05-22 21:03:43 +02:00
the-real-herowl
651fb74be1 Fix a crash 2024-05-22 21:03:43 +02:00
the-real-herowl
664993ca75 Fixed mob drops not having proper description 2024-05-22 21:03:43 +02:00
the-real-herowl
7a4c1ceba5 Legacy potion conversion extended 2024-05-22 21:03:43 +02:00
the-real-herowl
dbea863553 Legacy potions converter 2024-05-22 21:03:43 +02:00
the-real-herowl
d306260c7e Guardian fixes 2024-05-22 21:03:43 +02:00
the-real-herowl
cafa36d0b4 Add more sus stew effects 2024-05-22 21:03:43 +02:00
the-real-herowl
747bf16a94 Migrated mobs to the new effects API 2024-05-22 21:03:43 +02:00
the-real-herowl
55ce6f0f4b Migrated beacons to the new API 
Also added more effects to them
 2024-05-22 21:03:43 +02:00
the-real-herowl
e36b7f413b Strays now use frost arrows 2024-05-22 21:03:43 +02:00
the-real-herowl
dc7b1869b7 Move most of the game to the new API 2024-05-22 21:03:43 +02:00
the-real-herowl
bdaff930e0 Documentation update 2024-05-22 21:03:43 +02:00
the-real-herowl
a039e056a5 Support delayed drinking with new potions API 2024-05-22 21:03:43 +02:00
the-real-herowl
53d640028e Added effect stacking option to the potions API 
Also:
* Frost and Food Poisoning potion now stack their effects
* fixed a crash related to tipped arrows
 2024-05-22 21:03:43 +02:00
the-real-herowl
9e9507efeb Plant placement and drop fixes 2024-05-22 21:03:43 +02:00
the-real-herowl
63b2da7aa0 Added on_save_effect support for mobs 2024-05-22 21:03:43 +02:00
the-real-herowl
e806d5f3ce Fixed effects still being handled after mob death 2024-05-22 21:03:43 +02:00
the-real-herowl
914e3c6c2a Effects persist on loads for mobs too 2024-05-22 21:03:43 +02:00
the-real-herowl
a4eaaad1a9 Remove unused function in mcl_hunger 2024-05-22 21:03:43 +02:00
the-real-herowl
78ae5ddc26 Added some potion recipes 
Also:
* changed the duration of saturation and food poisoning potions
* minor code changes
 2024-05-22 21:03:43 +02:00
the-real-herowl
8f4d5d2e27 Added the ominous potion 2024-05-22 21:03:43 +02:00
the-real-herowl
70d8dfe558 Improved API mob support 
* various API functions now work with mobs properly
* the following effects don't work with mobs at all:
  water breathing, dolphin's grace, leaping, swiftness,
  slowness, slow falling, night vision, darkness, frost,
  health boost, absorption, fire resistance, resistance,
  luck, bad luck, blindness, nausea, hunger, saturation,
  haste, fatigue, conduit power
* the following effects should work with mobs:
  invisibility, regeneration, poison, withering,
  strength, weakness, levitation, glowing
* the following effects have no effect on mobs
  (but can be applied with the API):
  bad omen, hero of the village
 2024-05-22 21:03:38 +02:00
the-real-herowl
9b501bfa7e Allowed infinite effect duration 2024-05-22 21:02:25 +02:00
the-real-herowl
75e5ca8d49 Added the option to remove and clear effects... 
...with the /effect command.
Also made the API for clearing effects more robust.
 2024-05-22 21:02:25 +02:00
the-real-herowl
dcbc9d2398 Allowed giving effect without particles 
...both with API and the /effect command
 2024-05-22 21:02:25 +02:00
the-real-herowl
7c2d74e983 Typos fixed 2024-05-22 21:02:25 +02:00
the-real-herowl
7c1f9805e2 Tooltip and color fixes 2024-05-22 21:02:25 +02:00
the-real-herowl
b5367a77a7 Expanded brewing recipe API 
Added recipes using thick or mundane potion
 2024-05-22 21:02:25 +02:00
the-real-herowl
8cfe96a955 Added potions for new effects 
* also added some new brewing recipes
 2024-05-22 21:02:25 +02:00
the-real-herowl
ced2741686 Added strength and weakness potions 
Also fixed potent slowness potion level
Also fixed slowness and swiftness effect descriptions
 2024-05-22 21:02:25 +02:00
the-real-herowl
a9c2a89f16 New brewing recipes registering API 
Also migrated all recipes to the new system
 2024-05-22 21:02:25 +02:00
the-real-herowl
c4bedb37e0 Brewing fully works with the new system 2024-05-22 21:02:25 +02:00
the-real-herowl
f60f50041d Brewing somewhat works with the new API 2024-05-22 21:02:25 +02:00
the-real-herowl
09be413e3f Added glowing effect 
Also added on_save_effect callback to run cleanup
 2024-05-22 21:02:25 +02:00
the-real-herowl
7ae31790bf Fixed running on_end for effects that aren't ending 2024-05-22 21:02:25 +02:00