* Upgrade client active object mgr tests to Catch2
In addition to invoking Catch2's test runner after Minetest's homemade
runner, this refactors the tests to follow the DRY principle, and gives
them expressive names and clear assertions. Catch2 is already bundled
with Minetest, so there are no added dependencies.
* Increment failed modules count for Catch2 tests
* Respect --test-module option for Catch2 tests
* Improve Catch2 --test-module behavior
This switches infostream to rawstream so that test runner output is
displayed, and returns the correct boolean depending on the results. The
tests are now found by setting the configuration instead of invoking the
command line parser.
* Test uniqueness of all IDS instead of just one
Co-Authored-By: Lars Müller <appgurulars@gmx.de>
* Include Catch2 test run in timing and logging
* Flush std::cout after printing Catch results
* Increment total tests run instead of hardcoding to 1
* Flush stderr before printing to stdout
It's necessary to flush stderr before printing to stdout in adition to
flushing stdout before printing to stderr, to make sure all output is
ordered correctly.
* Make Catch write to rawstream
---------
Co-authored-by: Lars Müller <appgurulars@gmx.de>
To open the inventory or the pause menu, you first need to open the buttonbar
containing the respective button. Before this commit, the buttonbar is still
open after closing the menu, so you have to tap twice before you can continue
playing. After this commit, the buttonbar is already closed after closing the
menu, so you only have to tap once before you can continue playing.
Since this is fixed overhead for every entity, this is important to optimize.
This optimizes one very common case.
before:
push_collision_move_result [us] _____________ 64512x 3.562
after:
push_collision_move_result [us] _____________ 72636x 0.831
Fixes a regression caused by 4245a760
'moveItemSomewhere' attempted to add a leftover stack to an empty stack, resulting
in an empty name with non-0 ItemStack count.
