Commit Graph

11613 Commits

Author SHA1 Message Date
grorp
6c0b8229ec
Fix artifacts with bloom + tonemapping on ogles2 (#14688) 2024-05-23 20:36:13 +02:00
grorp
bc60693a5d
Enable "FULL" debug info for Android build (#14684) 2024-05-23 20:36:01 +02:00
JosiahWI
1298374818
Upgrade client active object mgr tests to Catch2 (#14565)
* Upgrade client active object mgr tests to Catch2

In addition to invoking Catch2's test runner after Minetest's homemade
runner, this refactors the tests to follow the DRY principle, and gives
them expressive names and clear assertions. Catch2 is already bundled
with Minetest, so there are no added dependencies.

* Increment failed modules count for Catch2 tests

* Respect --test-module option for Catch2 tests

* Improve Catch2 --test-module behavior

This switches infostream to rawstream so that test runner output is
displayed, and returns the correct boolean depending on the results. The
tests are now found by setting the configuration instead of invoking the
command line parser.

* Test uniqueness of all IDS instead of just one

Co-Authored-By: Lars Müller <appgurulars@gmx.de>

* Include Catch2 test run in timing and logging

* Flush std::cout after printing Catch results

* Increment total tests run instead of hardcoding to 1

* Flush stderr before printing to stdout

It's necessary to flush stderr before printing to stdout in adition to
flushing stdout before printing to stderr, to make sure all output is
ordered correctly.

* Make Catch write to rawstream

---------

Co-authored-by: Lars Müller <appgurulars@gmx.de>
2024-05-22 18:39:53 +02:00
Xeno333
a078cfee3e
Rename "opaque_water" setting to "translucent_liquids" with inverted meaning (#14660)
The old setting will be migrated properly.

---------

Co-authored-by: grorp <gregor.parzefall@posteo.de>
2024-05-22 16:46:05 +02:00
Lars Mueller
bd4572cfd1 Fix broken CI 2024-05-21 18:10:09 +02:00
sfence
df8a600b22
Fix glitch through ceiling with Sneak Glitch (#14332) 2024-05-21 17:52:54 +02:00
Lars Mueller
567f85752d Fix broken unit test
Also makes devtest unit test results a bit more prominent
2024-05-21 16:31:05 +02:00
Lars Mueller
5009259473 Add unit test and feature flag for override_item 2024-05-21 15:46:33 +02:00
sfence
b21a974342
Fix inventory: Quickly picking up item and placing it again no longer works (#14657) 2024-05-21 15:38:12 +02:00
chmodsayshello
ab783b9bb2
Display background & moving progress bar on shutdown screen (#14597)
Co-authored-by: Gregor Parzefall <gregor.parzefall@posteo.de>
2024-05-21 15:37:35 +02:00
sfan5
36d236c5e0
Update SDL for mingw builds (#14678) 2024-05-20 20:37:52 +02:00
Lars Müller
408faa11a1
Allow removal of item definition fields (#14675) 2024-05-20 20:37:40 +02:00
OgelGames
8972e829f2
Restore vector type check (#14663) 2024-05-20 20:36:44 +02:00
sfan5
c4703a7f19 Fix wrong collision axis in Lua moveresult
introduced by c24a04d246221e13a626f4a4dd34037a5332a935
2024-05-17 14:32:57 +02:00
grorp
f6cfe6b873
Enable RTTI for Irrlicht on MSVC (#14677) 2024-05-17 13:27:31 +02:00
Muhammad Rifqi Priyo Susanto
bceef8f529 Trivial fix (forget to remove semicolon) in gettext.cpp 2024-05-16 21:00:00 +07:00
AFCMS
b23042839b
Fixes to Docker GitHub Actions workflow 2024-05-15 19:56:50 +02:00
ROllerozxa
5625be70fa
Don't bundle Development Test on macOS 2024-05-15 19:56:41 +02:00
Lars Müller
5c187363b2
Fix some clang compiler warnings (#14654)
* Fix some clang compiler warnings

* Get rid of sdl_supports_primary_selection

* Fix draw2DImage hiding overloaded virtual function
2024-05-15 19:56:25 +02:00
sfan5
93f4844c9c Fix unintentional error message with dynamic media 2024-05-14 23:12:49 +02:00
sfan5
39fd9b93c3 Introduce proper error handling for file streams 2024-05-14 18:33:08 +02:00
sfan5
c38e0d05bf
Reenable fog toggle unless server restricts fog distance (#14634)
see comments in #14539
2024-05-14 18:31:51 +02:00
Josiah VanderZee
5a4d7fb0d6 Do not bother to assert that a u8 is >= 0
This fixes a warning seen in GCC 7 on CI about a comparison in
mapblock.h that is always true.
2024-05-14 16:21:30 +02:00
sfan5
6303334cc2 Deduplicate GL extension detection 2024-05-12 14:20:34 +02:00
sfan5
472742266b Fix invalid glDrawBuffer call on GLES
closes #14445
2024-05-12 14:20:34 +02:00
chmodsayshello
0889048cb5
Add option for random mod load order (#14637) 2024-05-12 14:20:18 +02:00
grorp
57b6e74abb
Fix crash if zip file cannot be opened (#14636)
Helped-by: savilli <78875209+savilli@users.noreply.github.com>
2024-05-12 11:46:39 +02:00
grorp
a8af0c0ca4
Close buttonbars when hiding TouchScreenGUI (#14630)
To open the inventory or the pause menu, you first need to open the buttonbar
containing the respective button. Before this commit, the buttonbar is still
open after closing the menu, so you have to tap twice before you can continue
playing. After this commit, the buttonbar is already closed after closing the
menu, so you only have to tap once before you can continue playing.
2024-05-10 18:54:22 +02:00
Benjamin Wheeler
07fe8d4481
Dockerfile: Use the default branch when cloning libspatialindex repository (#14621) 2024-05-10 17:00:15 +07:00
grorp
e0e1d0855d
Close formspecs with a single tap outside (#14605) 2024-05-09 19:16:08 +02:00
grorp
178591b6d5
Android CI: Additionally make an AAB for uploading to the Play Store (#14584) 2024-05-09 19:15:50 +02:00
sfan5
dd475d8af4 Add benchmarks for server::ActiveObjectMgr 2024-05-09 11:31:35 +02:00
Licaon_Kter
121d22f137
Cleanup Removed Java 17 Options (#14626)
ref: https://docs.oracle.com/en/java/javase/17/docs/specs/man/java.html#removed-java-options
2024-05-09 11:31:22 +02:00
sfan5
59bf1d8cd9
Fix curl compatibility issues with colorize_url (#14615)
Also move the escape code safety check to guiOpenURL.
2024-05-09 11:31:10 +02:00
jordan4ibanez
780543f0a2 Add forgotten opensuse dependency
gcc-c++
2024-05-09 00:22:36 +02:00
sfan5
de78ffb551 Fix strings in modified_reason_strings
one was also missing
2024-05-09 00:19:24 +02:00
sfan5
1aba7f1fde
Add unit tests for MapBlock (de)serialization (#14560) 2024-05-05 22:54:40 +02:00
rubenwardy
3017b0213b
Allow quoting hypertext attribute values (#14550) 2024-05-05 14:27:17 +02:00
sfan5
d748c8c653 Gate disabling of fog or camera update behind 'debug' priv 2024-05-05 14:26:56 +02:00
grorp
af8cb63292
Add object's own position for each collision to moveresult (#14608) 2024-05-05 13:28:59 +02:00
grorp
d7f9da49eb
Fix shootline not being updated if press and release happen in the same step (#14606) 2024-05-05 13:28:50 +02:00
Lars Mueller
70bddcf318 Fix wrong name for bone override interpolation field 2024-05-04 02:09:35 +02:00
SmallJoker
f0bb5313d3 Chat console: Prevent input loss on double open 2024-05-03 16:29:33 +02:00
DS
c352fbf5c9
Warn on unknown CMAKE_BUILD_TYPE values (#14600) 2024-05-03 16:29:02 +02:00
sfan5
9c3c286aab Optimize code patterns around raycasting 2024-05-03 16:28:29 +02:00
sfan5
e10adf83d5 Reduce wasteful memory allocations in update_lighting_nodes() 2024-05-03 16:28:29 +02:00
sfan5
c24a04d246 Optimize pushing collision data for entity on_step
Since this is fixed overhead for every entity, this is important to optimize.
This optimizes one very common case.

before:
  push_collision_move_result [us] _____________ 64512x   3.562

after:
  push_collision_move_result [us] _____________ 72636x   0.831
2024-05-03 16:28:29 +02:00
sfan5
2e89529eef Optimize env access and structs in collisionMoveSimple 2024-05-03 16:28:29 +02:00
sfan5
92d03f3832 Trivially optimize iteration order in loops
Due to how node data is stored iterating X last provides better cache locality.
2024-05-03 16:28:29 +02:00
Lars Müller
2efd0996e6
Document empty string as form name (#14601) 2024-04-30 13:50:31 +02:00