Commit Graph

5679 Commits

Author SHA1 Message Date
hydroflame
1b7b4fa466
Merge pull request #4249 from Snarling/typeAssertion
NETSCRIPT: Fix ns.prompt typechecking
2022-10-19 11:44:59 -04:00
hydroflame
b25b4b5e27
Merge pull request #4255 from quacksouls/doc-gang-canRecruitMember
DOC: `gang.canRecruitMember()`: typo fix and elaboration
2022-10-19 11:44:03 -04:00
Olivier Gagnon
c3b2c6396c lint and made a some code more robust to older save file 2022-10-16 14:25:42 -04:00
Duck McSouls
6f1822bf4d DOC: gang.canRecruitMember(): when this returns true or false
Elaborate on the conditions under which the function would return true or false.  In particular, after a gang is successfully created the function always return true so the player can recruit a number of founding members to their gang.  When the gang is at capacity, the function always return false.  In between, the function returns true or false depending on the amount of respect the player has.
2022-10-16 18:34:34 +11:00
Duck McSouls
ac0e7c9595 DOC: gang.canRecruitMember(): typo fixes
Some typographical fixes.
2022-10-16 17:56:45 +11:00
Duck McSouls
93090691b5 DOC: ns.prompt(): some examples
Add some examples to illustrate the use of the various options.  As per suggestion by @Snarling, simplify the examples on free-form text box and drop-down list.
2022-10-15 11:27:56 +11:00
Duck McSouls
473e6a2674 DOC: ns.prompt(): explain the various options
Elaborate on the effects of `options.type` and `options.choices`.  Break the explanation into bullet points for clearer presentation.  Thanks to @Snarling for pointing out that the default is to create a boolean dialog box.
2022-10-15 11:03:36 +11:00
omuretsu
9908f4aaa5 Error message fixes 2022-10-14 11:08:24 -04:00
omuretsu
7683990d17 format and lint 2022-10-14 11:03:50 -04:00
omuretsu
ad0be471ce fix ns.prompt typechecking
Introduced some new type assertion functions, initial step in larger type safety rework.
2022-10-14 11:00:29 -04:00
borisflagell
baa149fa80 Update HospitalLocation.tsx
Add auto-refreshing to the component
2022-10-14 14:13:53 +03:00
borisflagell
1b61ec0e12 Update HospitalLocation.tsx 2022-10-14 13:59:56 +03:00
Duck McSouls
a368c6904e DOC: ns.prompt(): a typo fix
A simple typographical fix.
2022-10-14 14:50:35 +11:00
Daniel Bachran
5acd5e84a3 #4239 Adjust write() documentation
write() only accepts strings now.
2022-10-13 17:45:40 +02:00
Olivier Gagnon
6c84d64e67 rm unecessary return type 2022-10-13 01:07:10 -04:00
Olivier Gagnon
4c4f050214 simplify get money source 2022-10-13 00:55:57 -04:00
Olivier Gagnon
8ff840edfa getBitnodeM takes 2 arg 2022-10-13 00:51:53 -04:00
Olivier Gagnon
ae5fc168bf Add getMoneySources 2022-10-13 00:10:59 -04:00
hydroflame
d0fe28f8fb
Merge pull request #4220 from cptpiepmatz/fix-nano-not-opening-root-script-if-in-dir
UI: Fixed `nano` not correctly opening a script in root of a server if `cd`'d into a directory
2022-10-12 23:58:59 -04:00
hydroflame
14914eb190
Merge pull request #4229 from borisflagell/wxsQDSSQF
SLEEVE: Fix #4194 Bladeburner Contract in Sleeve were not giving proper reward.
2022-10-12 23:54:15 -04:00
hydroflame
93769c7089
Merge pull request #4224 from quacksouls/doc-scan
DOC: `ns.scan()`: typo fixes and add 2 examples
2022-10-12 23:52:34 -04:00
hydroflame
aa39728f67
Merge pull request #4230 from borisflagell/SoA_RepCost
SOA: Fix #3884 Implement unused SoARepMult constant to SoA's augmentations price + linked UI modification
2022-10-12 23:52:14 -04:00
hydroflame
50bc41bf5b
Merge pull request #4231 from borisflagell/TypoRepReq#3811
API: Fix #3811 Update NetscriptDefinitions.d.ts
2022-10-12 23:51:39 -04:00
hydroflame
c1ab4e82f2
Merge pull request #4232 from borisflagell/UI_reputation_color
UI: Fix #3719 Inconsistent colors of reputation gains on Install Augmentations screen
2022-10-12 23:51:23 -04:00
hydroflame
74a1b9b180
Merge pull request #4234 from Jakob002/Jakob002-patch-1
MISC: Fixed typo in Literatures.ts
2022-10-12 23:51:10 -04:00
hydroflame
68e90b8e6e
Merge pull request #4236 from Snarling/typeFix
NETSCRIPT: Fix internal typechecking of functions
2022-10-12 23:50:22 -04:00
omuretsu
e192ad53ec Actually format + lint 2022-10-12 10:18:56 -04:00
Jakob002
c2ed9067e0
MISC: message formatting
Replaced someArray.toString() with someArray.join(", "). This will return "foo, bar, baz" (with spaces) instead of "foo,bar,baz" (no spaces).
2022-10-12 15:16:10 +02:00
omuretsu
7a384d53f4 typefix netscriptFunctions (see desc)
* Types for InternalFunction and ExternalFunction have been modified to actually typecheck ns functions against docs.
* Internal functions are required to use unknown for any params on the inner function.
* Return types for internal function inner-function must match the respective external function.
* Added new typecheck assertion function for asserting dynamic object types, to allow unknownifying params that were previously hardcoded objec structures.
* Because type assertion for parameter types and return types is enforced by InternalAPI, removed all duplicate type declarations on NetscriptFunction params and returns.
2022-10-12 08:49:27 -04:00
Jakob002
fc50625dcf
Fixed typo in Literatures.ts 2022-10-12 08:47:03 +02:00
omuretsu
41b6f0b87b add hoop before exposing 2022-10-11 21:02:04 -04:00
omuretsu
7d07f44b3e move to global scope 2022-10-11 20:01:10 -04:00
omuretsu
84b99c569a extra printRaw function 2022-10-11 16:07:45 -04:00
borisflagell
b3f2fe5e02 Update PlayerMultipliers.tsx 2022-10-11 19:22:06 +03:00
borisflagell
def2cb281b Update AugmentationsPage.tsx 2022-10-11 19:03:58 +03:00
borisflagell
b2886ba623 Update NetscriptDefinitions.d.ts 2022-10-11 18:45:38 +03:00
borisflagell
6c625a5ca3 Update AugmentationsPage.tsx 2022-10-11 18:30:41 +03:00
borisflagell
5c1777a6d4 Update AugmentationsPage.tsx
Tooltip's text refining
2022-10-11 18:29:17 +03:00
borisflagell
125cd04383 Fix #3884
Fix #3884
2022-10-11 18:12:06 +03:00
borisflagell
bbe6421b06 Update Bladeburner.tsx
Prettier
2022-10-11 15:33:55 +03:00
borisflagell
f3becee15b Fix Bladeburner Contract in Sleeve 2022-10-11 15:25:16 +03:00
Duck McSouls
b03288a700 DOC: ns.scan(): add 2 examples
The first example shows how to use `ns.scan()` without passing an argument.  The second example uses `ns.scan()` by passing the hostname of a target server.  Both examples can be written more succinctly by using the `forEach()` method of array, but for the purposes of illustration the `for` loop should be easier for beginners to read.
2022-10-11 18:48:47 +11:00
Duck McSouls
afe6a837c3 DOC: ns.sleeve.setToCommitCrime(): add 1 example
An example on how to set a sleeve to commit a crime.  The example shows that sleeves are indexed from 0.
2022-10-10 20:49:33 +11:00
Duck McSouls
c728c550f5 DOC: ns.sleeve.setToCommitCrime(): add all crimes a sleeve can commit
Add a list of crimes that a sleeve can commit.  Update the parameter documentation to refer to this list.
2022-10-10 13:18:00 +11:00
Duck McSouls
304b7645b0 DOC: ns.sleeve.setToCommitCrime(): starting index of sleeves
Document the index of the first sleeve.  Sleeves are indexed starting from zero, i.e. 0.  Increment by 1 to get the index of the next sleeve.  And so on.
2022-10-10 12:47:20 +11:00
Duck McSouls
67f5d60116 DOC: ns.scan(): typo fixes
Some typographical fixes in the documentation of the function `ns.scan()`.  The function returns an array, not a string.
2022-10-10 09:55:31 +11:00
Olivier Gagnon
f803355335 fix doc 2022-10-09 18:48:58 -04:00
Olivier Gagnon
7a89c0a1bb regen doc 2022-10-09 18:46:13 -04:00
Olivier Gagnon
cbb7f58231 Make the main player object an alias, makes it easier to import 2022-10-09 18:42:14 -04:00
Tim Hesse
7121b456f4 fix: nano does not open root script if cd'd into a dir 2022-10-09 14:49:18 +02:00
Olivier Gagnon
3c03ac4f18 fix fileExists not finding coding contrafcts 2022-10-09 02:57:43 -04:00
Olivier Gagnon
f4668b21ca functions to generate dummy contracts 2022-10-09 02:56:11 -04:00
Olivier Gagnon
5d4b72e1d1 Added some purchased server functions 2022-10-09 02:32:13 -04:00
Olivier Gagnon
0fdf74ceeb typo 2022-10-09 01:32:44 -04:00
Olivier Gagnon
f6f023eeb4 Fix tons of typos 2022-10-09 01:25:31 -04:00
hydroflame
f8a3a046de
Merge pull request #4156 from G4mingJon4s/contractFix
Coding Contract: Saving and reloading no longer generates extra coding contracts.
2022-10-09 00:31:42 -04:00
hydroflame
608ea0ba59
Merge pull request #4196 from connertennery/4125
INFILTRATION: Slash minigame fixed so attacking when the guard is preparing doesn't cause failure, fixed indicator when player has Might of Ares augmentation
2022-10-09 00:29:59 -04:00
hydroflame
87ad634859
Merge pull request #4201 from stalefishies/has-augmentation-fix
MISC: Fix bug in person.hasAugmentation
2022-10-09 00:27:05 -04:00
hydroflame
b0ba0b30b5
Merge pull request #4211 from fdellwing/patch-2
FACTION: Include BN multiplier in faction donation
2022-10-09 00:26:16 -04:00
hydroflame
0e26515c81
Merge pull request #4213 from borisflagell/SleeveZOE
STANEK: Reapply aug's multiplier to sleeve when applying Stanek gift to them
2022-10-09 00:25:52 -04:00
hydroflame
c930487c21
Merge pull request #4215 from borisflagell/crime-sleeve
SLEEVE: Fixes 2 issues in Sleeve's implementation of crime work
2022-10-09 00:25:13 -04:00
hydroflame
a5b2512269
Merge pull request #4205 from Snarling/ramTestFix
TESTS: Refined ram calculation tests
2022-10-09 00:23:04 -04:00
hydroflame
b4d6ead5d2
Merge pull request #4206 from quacksouls/doc-exec
DOC: `ns.exec()`: typo fixes and clean presentation
2022-10-09 00:22:54 -04:00
hydroflame
ed0a28d292
Merge pull request #4207 from quacksouls/doc-prettier
DOC: no trailing whitespace
2022-10-09 00:22:25 -04:00
borisflagell
6d86852969 FIX crime by sleeve
Bitnode multiplier was applied twice in th UI.
Sleeve's multiplier weren't applied (neither in UI, nor engine).
2022-10-08 17:19:20 +03:00
borisflagell
08b6c7a177 Fix #4195
Whenever StanekGift updated Sleeve's mult,
all mult were reset to default value (1.0 usually).
then stanek mult were merged.
but aug's mults never were.

=> Added a small loop to StanekGift updateMults() which reapply Aug's mult.
2022-10-08 15:28:51 +03:00
Duck McSouls
1d739f295c DOC: gang task: typo fix
The current version `black mail` should be `blackmail` because the description is referring to the crime of blackmail.
2022-10-08 14:21:30 +11:00
Fabian Dellwing
ea39e5e1f4
Include BN multiplier in faction donation 2022-10-07 21:28:19 +02:00
Duck McSouls
351d769122 DOC: no trailing whitespace
Remove some trailing whitespaces in `src/ScriptEditor/NetscriptDefinitions.d.ts` because `npm run format` complains about them.  The trailing whitespaces were introduced in one of my earlier patches.  Sorry about this :-(
2022-10-06 23:29:06 +11:00
Duck McSouls
e3ace9f6d5 DOC: ns.exec(): break example comments into multiple lines
The comment of each example is so long that, in the generated documentation for `ns.exec()` shown at

https://github.com/danielyxie/bitburner/blob/dev/markdown/bitburner.ns.exec.md

you must use the horizontal scrollbar to read the whole comment.  Even if you maximize the browser window, you must still use the horizontal scrollbar to read the whole comment.  Tested on Brave, Chrome, Firefox, and Opera.  Fix this by limiting each line of comment to at most 90 characters.
2022-10-06 22:56:01 +11:00
Duck McSouls
5edcdaad81 DOC: ns.exec(): typo fixes
Some typographical fixes in the documentation of `ns.exec()`.  Link to the function `ns.run()`.  Currently, the line `* * @example` causes API Extractor to output an asterisk (i.e. `*`) between the two code examples.  The function `ns.exec()` calls the function `runScriptFromScript()` from `src/NetscriptWorker.ts`, which uses the floor function to round down the number of threads.
2022-10-06 22:34:00 +11:00
Snarling
0310a98237 Lint+format fix? 2022-10-05 15:29:56 -04:00
Snarling
068533cd2f format, lint, more enums, revert fn rename 2022-10-05 14:52:48 -04:00
Snarling
8bb88a5080 Better RamCost testing (see desc)
* RamCostGenerator will have an error if ramcosts are defined for nonexistent functions, in addition to error if not all functions have ram costs defined
* Removed a few random blank comment lines in NetscriptDefinitions.d.ts
* RamCalculation.test.ts checks exact expected static and dynamic ram usage from (almost) every function, based on defined RamCosts in RamCostGenerator.
2022-10-05 10:42:07 -04:00
Staszek Welsh
ad8c7b7ffe Fix change in behaviour of person.hasAugmentation 2022-10-04 22:55:35 +01:00
Conner Tennery
40e8e82b6d
Merge branch 'dev' into 4125 2022-10-04 09:39:12 -07:00
hydroflame
4d1e72bf7a
Merge pull request #4172 from Snarling/IPs-fix
CCT: Generate IPs contract type accepts properly formatted js array
2022-10-04 11:58:26 -04:00
hydroflame
075daf6fac
Merge pull request #4175 from mycroftjr/patch-2
BLADEBURNER: Make Datamancer apply to Tracking
2022-10-04 11:47:46 -04:00
hydroflame
5b699fa19f
Merge pull request #4188 from quacksouls/doc-stock
DOC: `stock.getPrice()`: typo fixes and update examples
2022-10-04 11:47:24 -04:00
hydroflame
2b8ced4fff
Merge pull request #4182 from OverlordQ/patch-1
MISC: Remove spurious console spam
2022-10-04 11:45:09 -04:00
hydroflame
774c3ef402
Merge pull request #4185 from quacksouls/doc-print
DOC: `print()` and friends: typo fixes and examples
2022-10-04 11:45:01 -04:00
Snarling
361466b7fa unasync trywriteport 2022-10-04 07:59:50 -04:00
Snarling
aa80cf6451 See description
Reverted ToastVariant back to an enum internally. Still exposed to player as just possible strings.
Changed all 1-line documentation comments to actually be 1-line. Moved some because they were not providing documentation for the thing they were trying to.
2022-10-04 06:40:10 -04:00
Snarling
50f14b4f58 Commit1 2022-10-03 12:12:16 -04:00
Conner Tennery
0d6b6b404d
fix "Slash when his guard is down!" actually means "Slash when he's attacking!" Also the Might of Ares timer is wrong. #4125
- Added ignoreAugment_WKSharmonizer to GameTimer to allow for strict, unmodified timers
- Changed SlashGame failure check
- Changed `timeUntilAttacking` value so the progress bar in SlashGame is accurate
2022-10-03 01:42:17 -07:00
Duck McSouls
01e7ce2a05 DOC: stock.getPrice(): a simple example
Fixes #4184. The hard-coded stock symbol `"FISG"` should be `"FSIG"`.
2022-10-02 11:39:54 +11:00
Snarling
ab56d18e1e group initializers 2022-10-01 15:49:23 -04:00
Snarling
3addda7173 format and lint 2022-10-01 15:15:36 -04:00
Snarling
9774235404 initial test fix attempt 2022-10-01 15:03:47 -04:00
Duck McSouls
4cf270138d DOC: stock.getPrice(): typo fix in examples
Fixes #4184.  The hard-coded stock symbol `"FISG"` should be `"FSIG"`.  The updated examples do not use a hard-coded stock symbol.  The documentation is updated to explain under which circumstances a player can run the function `stock.getPrice()`.
2022-10-01 10:07:20 +10:00
Duck McSouls
5e14d07d9a DOC: stock.getPrice(): typo fixes
Some typographical fixes for the documentation of `stock.getPrice()`.  The line for RAM cost should be separated by a blank line from the sentence about the definition of a stock's price.  Otherwise `npm run doc` would cram those information together onto one line.
2022-10-01 09:59:44 +10:00
Duck McSouls
0488f6e7b3 DOC: print() and friends: some examples
Some examples for how to use `print()` and related functions.  Use cross-referencing to reduce duplicate examples.
2022-09-30 14:22:49 +10:00
Duck McSouls
ebdeb15d5a DOC: print() and friends: typo fixes
Some typographical fixes.  In the generated documentation for `tprintf()`, the documentation for the parameter `values` is missing because `@param msg` should be `@param values`.
2022-09-30 14:19:19 +10:00
OverlordQ
046ba80935
Update killWorkerScript.ts
Remove spurious console debugging line
2022-09-29 08:20:49 -04:00
hydroflame
5e4a393495
Merge pull request #4180 from Snarling/growthAnalyzeSecurityFix
NETSCRIPT: growthAnalyzeSecurity no longer fails if the optional cores parameter was omitted
2022-09-29 01:09:21 -03:00
Snarling
b682d441e3 better fix for cores check 2022-09-29 00:02:33 -04:00
Snarling
17be0911b2 fix growthAnalyzeSecurity 2022-09-28 23:59:58 -04:00
Olivier Gagnon
cb064ce8d7 fix new save file not loading 2022-09-28 23:35:01 -04:00
MycroftJr
c7d85e1d42
Make Datamancer apply to Tracking
Makes the Datamancer skill for Bladeburner apply to the Population Estimate change of the Tracking contract. If this was not desired, then the description of Datamancer needs to be made more accurate :D
2022-09-27 22:08:14 -07:00
Snarling
a1f90d77ce Prettier fix 2022-09-27 19:58:14 -04:00
Snarling
73e314aa31 Add quotation marks to expected answer
Matches the way an array of strings is denoted in js
2022-09-27 19:52:25 -04:00
Snarling
aba6de1514 Allow IPs to have quotes around them 2022-09-27 19:41:00 -04:00
Olivier Gagnon
444c74ccd9 Merge branch 'dev' of github.com:danielyxie/bitburner into dev 2022-09-27 17:37:36 -04:00
Olivier Gagnon
fbf5009cdb comment out unnamedaug2 2022-09-27 17:37:32 -04:00
hydroflame
7ce1adddce
Merge pull request #4151 from LJNeon/script-editor-fix
UI: Remove extra / from open script tab when files are in a folder
2022-09-27 17:50:32 -03:00
hydroflame
a1df9db493
Merge pull request #4160 from quacksouls/cct-name
CCT: no special characters in file names of Coding Contracts
2022-09-27 17:50:08 -03:00
hydroflame
30363e0280
Merge pull request #4155 from Mughur/corp
CORP: fixed wrongly named division type
2022-09-27 17:49:09 -03:00
hydroflame
49a460af00
Merge pull request #4161 from Snarling/cityFix
UI: Fix possible React error 300 in ASCII version of city screen
2022-09-27 17:47:54 -03:00
Snarling
582c9f40e2
Merge branch 'dev' into cityFix 2022-09-27 16:38:39 -04:00
Snarling
a4b7128e6c Sleeve bladeburner fix 2022-09-27 16:36:37 -04:00
Snarling
16fac67257 fix broken rebase 2022-09-27 16:23:53 -04:00
Snarling
25be5c2990 Remove unused augmentationStats interface
All augmentations have all multipliers
2022-09-27 16:20:26 -04:00
Snarling
3d4d02a573 remove unnecessary function 2022-09-27 16:15:11 -04:00
Snarling
38063f62a7 build fix, lint, remove some instanceof checks 2022-09-27 16:09:32 -04:00
Snarling
81412db02e format & lint fix 2022-09-27 16:09:32 -04:00
Snarling
b364cdf734 Rebase fix, move hasAugmentation to Person 2022-09-27 16:08:52 -04:00
Snarling
8a9515f154 More classes as types 2022-09-27 16:08:16 -04:00
Snarling
0dbe80a841 Player is now a Person
Use correct class inheritance, use class as type and remove IPlayer
2022-09-27 16:07:58 -04:00
Snarling
bc2bdbe137 revert unnecessary file rename 2022-09-27 16:03:36 -04:00
Snarling
5f0758d04c Fix lit files, reallow html alerts 2022-09-27 16:03:36 -04:00
Snarling
c5f2b959f6 commit1 2022-09-27 16:02:09 -04:00
Snarling
3a139518d8 unified errors 2022-09-27 15:53:45 -04:00
Snarling
0e67fbee21 Unify error handling 2022-09-27 15:51:25 -04:00
Snarling
ba1a10b4f7 Unify error handling 2022-09-27 15:46:34 -04:00
Snarling
88505e9378 stray lint fix 2022-09-27 15:35:42 -04:00
Snarling
e5e6b05be0 format+lint+build fix 2022-09-27 15:35:42 -04:00
Snarling
37d9b0c78d Fix gang faction type 2022-09-27 15:35:42 -04:00
Snarling
6e3a6be106 Remove some redundant typing 2022-09-27 15:35:42 -04:00
Snarling
db835862d7 format 2022-09-27 15:35:42 -04:00
Snarling
bc7c15ad77 corp: classes are types 2022-09-27 15:35:42 -04:00
Snarling
557bc12562 More classes as types 2022-09-27 15:35:42 -04:00
Snarling
2213d06159 Using bladeburner and action classes as types 2022-09-27 15:35:41 -04:00
Snarling
c510e47885 Player is now a Person
Use correct class inheritance, use class as type and remove IPlayer
2022-09-27 15:35:41 -04:00
Snarling
475a8812bb findSleevePurchasableAugs as a class member 2022-09-27 15:35:41 -04:00
Snarling
dcd9023b93 Remove more unused interfaces 2022-09-27 15:35:41 -04:00
Snarling
e578bd7681 Remove IPlayer interface
Use PlayerObject instead when referring to the type of "The Player."
2022-09-27 15:35:41 -04:00
Snarling
21a2d49de7 Finish removing player passing 2022-09-27 15:35:41 -04:00
Snarling
c864fd7edf revert unnecessary file rename 2022-09-27 15:35:41 -04:00
Snarling
dc59a10e19 Fix lit files, reallow html alerts 2022-09-27 15:35:40 -04:00
Snarling
88e2cdf09c Remove more execute-on-import code 2022-09-27 15:35:40 -04:00
Snarling
1ac57d2e48 Fix use-before-defined import issue 2022-09-27 15:35:40 -04:00
Snarling
91a69d7d8f format & lint 2022-09-27 15:35:40 -04:00
Snarling
c9ee938bc6 fix previous commit 2022-09-27 15:35:40 -04:00
Snarling
a21b1029d7 No more player/router context 2022-09-27 15:35:40 -04:00
Snarling
83d357e758 commit1 2022-09-27 15:35:40 -04:00
Snarling
cc2246213f Add more error types 2022-09-27 15:35:39 -04:00
Snarling
824d8db653 simplify/dehardcode failOnHacknetServer 2022-09-27 15:35:39 -04:00
Snarling
83c62bbc63 silent fail for tabcompletion compile error 2022-09-27 15:35:39 -04:00
Snarling
7d37736058 unified errors 2022-09-27 15:35:39 -04:00
Snarling
8d0347577d Less hardcoding 2022-09-27 15:34:48 -04:00
Snarling
b8496b4c2c remove duplicate handling 2022-09-27 15:34:48 -04:00
Snarling
74be61cbdd remove unnecessary return 2022-09-27 15:34:48 -04:00
Snarling
caf1a99c1d More reliable error message for ScriptDeaths 2022-09-27 15:34:48 -04:00
Snarling
ad356cf28f format/lint 2022-09-27 15:34:48 -04:00
Snarling
572c68738f Unify error handling 2022-09-27 15:34:47 -04:00
Snarling
5798c4c7d3 Unify error handling 2022-09-27 15:32:09 -04:00
hydroflame
8f4636cbb4
Merge pull request #4166 from Snarling/ns1wrapfix
NETSCRIPT: NS1 wrapper no longer fails to properly wrap some functions
2022-09-27 14:36:27 -03:00
Olivier Gagnon
c94f6c1758 Merge branch 'dev' of github.com:danielyxie/bitburner into dev 2022-09-27 13:35:56 -04:00
Olivier Gagnon
2fc17423ff Improve the robustness of the tutorial. 2022-09-27 13:35:51 -04:00
Snarling
21f7b7ad06 Fix ns1 Wrapper 2022-09-27 00:03:16 -04:00
Mughur
c462da9147
Double checking small fixes would be a good idea 2022-09-27 05:02:12 +03:00
G4mingJon4s
fd9bdb3b65 Readded randomness for lower values of chances 2022-09-26 19:19:03 +02:00
Snarling
d55d7a05be Revert "Fix ram usage of scp-overwritten files"
This reverts commit 3dbc848098f10545d66a5dbf9d18b3d286953154.
2022-09-26 10:44:57 -04:00
Snarling
21c919c030 Fix react error in ASCIICity 2022-09-26 10:39:09 -04:00
Duck McSouls
819e102fe1 CCT: no special characters in file names of Coding Contracts
Fixes #4067.  The file name of a Coding Contract follows the format contract-xxx-rewardName.cct.  The part `xxx` means a sequence of random decimal digits.  The part `rewardName` can be an empty string if the player is not part of any faction nor is working for a company.  However, if the player is working for a company or faction whose name has a special character, then the special character would also appear in the generated file name.  We only want alphanumeric characters throughout the whole file name.
2022-09-27 00:01:21 +10:00
Snarling
3dbc848098 Fix ram usage of scp-overwritten files 2022-09-26 09:31:49 -04:00
G4mingJon4s
a1ff3a2058 Fix for #4111 2022-09-25 12:37:20 +02:00
Mughur
1ee292bde9
CORP: fixed wrongly named division type
"Computer" division type was erroneously named "Hardware"
2022-09-25 06:19:18 +03:00
LJNeon
a464563e1c
chore(ScriptEditor): Remove extra / from files in a folder 2022-09-23 19:23:54 -07:00
hydroflame
69eda4340e
Merge pull request #4146 from LJNeon/office-size-fix
CORPORATION: Don't show repeat office size upgrade button
2022-09-23 16:20:48 -03:00
Olivier Gagnon
a3c92dd04d Wrap up v2.1.0 2022-09-23 15:00:20 -04:00
LJNeon
4aed5da4ee
feat(corp): don't show repeat office size upgrade button 2022-09-23 11:38:58 -07:00
Olivier Gagnon
f43d232928 upgrade version number. 2022-09-23 12:52:30 -04:00
Olivier Gagnon
6390f3618e Added few augs 2022-09-23 12:05:16 -04:00
Olivier Gagnon
fb197be206 Fix hostname generation being weird about dash 0 added 2022-09-23 12:04:21 -04:00
hydroflame
cbe31fa63f
Merge pull request #4135 from Mughur/corp
CORPORATION: FIX #3880, #3876, #3322 and #3138 Bunch of corporation fixes
2022-09-23 12:35:11 -03:00
hydroflame
8a694c4c1e
Merge pull request #4136 from quacksouls/typo
DOC: Some typo fixes in Netscript functions
2022-09-23 12:32:57 -03:00
hydroflame
2cce14a95b
Merge pull request #4139 from Mughur/Sleeve
MISC: crime gains, sleeve gang augs and faq
2022-09-23 12:32:15 -03:00
hydroflame
1b329df398
Merge pull request #4141 from LJNeon/tformat-fix
API: Remove incorrectly placed 's' in ns.tFormat()
2022-09-23 12:30:18 -03:00
LJNeon
b1c5ddb211
chore(ns.tFormat): Remove incorrectly placed 's' 2022-09-23 07:59:50 -07:00
Mughur
5e0d284cf0 updated sleeve FAQ 2022-09-23 16:01:53 +03:00
Mughur
a389974314 Sleeves now only get actual gang's augs 2022-09-23 15:52:04 +03:00
Mughur
33b304bff5 Crime gains now properly affected by player mults 2022-09-23 15:17:48 +03:00
Duck McSouls
5f47536d54 CCT: inconsistent probability for generation between online and offline
Fixes #4110.  While online, there is 25% chance for a Coding Contract to appear.  The same should apply when a player loads the game after being offline for a period of time.  Currently, loading the game after being offline would give a generation probability of less than 25%.  The mismatch between offline and online gives an unfair advantage to having the game running for an extended period of time.
2022-09-23 21:38:27 +10:00
Duck McSouls
0a644aed58 Typo fix in ns.singularity.workForFaction()
Abbreviation of "you are" is "you're".  Also place a full stop at the end to complete the sentence.  Fixes #4118.
2022-09-23 20:32:53 +10:00
Mughur
d99d37f191 Bunch of corporation fixes 2022-09-23 13:13:33 +03:00
Duck McSouls
98d43acf9f Missing capitalization in ns.gang.ascendMember()
The return description of the function ns.gang.ascendMember() has a missing capitalization.  Fixes #4091.
2022-09-23 20:06:36 +10:00
Duck McSouls
b31c64fb9f Missing capitalization in ns.gang.getAscensionResult()
The return description for the function ns.gang.getAscensionResult() has a missing capitalization. Fixes #4090.
2022-09-23 20:03:46 +10:00
Duck McSouls
b0f1e7a997 Typo fix for focus parameter of ns.singularity.commitCrime()
The focus parameter of the function ns.singularity.commitCrime() relates to committing a crime, not creating a program.  Fixes #4127.
2022-09-23 20:01:21 +10:00
hydroflame
b8f8246294
Merge pull request #4134 from Shiiyu/dev
MISC: FIX #3649 Preventing server starting security level from going above 100
2022-09-23 03:42:09 -03:00
Shiiyu
e1bff8bcb1 fix: 🐛 fix server minimum difficulty changing when server starting difficulty is capped 2022-09-23 02:39:58 -04:00
Shiiyu
cf11612abc style: 🎨 fix - forgot to run format first 2022-09-23 02:07:32 -04:00
Olivier Gagnon
66e80b2efa Added more info about blood program, change some aug descriptions 2022-09-23 01:13:37 -04:00
Shiiyu
ecaa906682 fix: 🐛 fix server starting security going above 100 2022-09-23 00:42:47 -04:00
hydroflame
2a43b90ed3
Merge pull request #4039 from ezylot/patch-1
GANG: Added weight to GangMemberTask construction call
2022-09-23 01:15:29 -03:00
Olivier Gagnon
fde4e7ac38 fix 2962 2022-09-23 00:13:06 -04:00
hydroflame
944ee71ab9
Merge pull request #4065 from Snarling/sleeveBladeContractFix
SLEEVES: FIX #4063 fix crash when player tries to assign more than 3 sleeves to Bladeburner contracts
2022-09-23 00:59:46 -03:00
hydroflame
5101b345ec
Merge pull request #4069 from Mughur/corp
API: Corp functions now return copy of constant arrays instead of the original
2022-09-23 00:58:32 -03:00
hydroflame
ee67aa90f9
Merge pull request #4131 from Mughur/valuation
CORPORATION: Gave investors some economics classes
2022-09-23 00:58:06 -03:00
hydroflame
ed14f2a4d7
Merge pull request #4072 from Snarling/exitExits
NETSCRIPT: FIX #2376 ns.exit now exits immediately
2022-09-23 00:57:15 -03:00
hydroflame
b139d689a5
Merge pull request #4103 from G4mingJon4s/dev
Fix for #2442 and #2795.
2022-09-23 00:56:40 -03:00
Olivier Gagnon
2a0dd6b6f8 Minor improvements to Netscript Port loading and unloading 2022-09-22 23:55:16 -04:00
hydroflame
0044761fd3
Merge pull request #4073 from Hoekstraa/unlimited-ports
API: More ports (previously max 20, now practically unlimited)
2022-09-23 00:51:50 -03:00
hydroflame
a8e640e309
Merge pull request #4084 from Rasmoh/expose_exports
CORPORATION API: FIX #3655 Expose exports from Material
2022-09-23 00:46:28 -03:00
Olivier Gagnon
4f64d3eeb1 use triple equal 2022-09-22 23:45:00 -04:00
hydroflame
9f922de50d
Merge pull request #4101 from Kelenius/UnhardcodeBBAndCorpDisabling
UI: Bitnode stats now show if BB/Corporation are disabled
2022-09-23 00:43:19 -03:00
hydroflame
23c889bafd
Merge pull request #4074 from phyzical/hotfix/4058
CORP API: Fix up param order for limitProductProduction to match docs
2022-09-23 00:36:24 -03:00
hydroflame
5d6eed2b4d
Merge pull request #4082 from Snarling/tailRamExploitFix
SCRIPTS: FIX #4081 Rerunning a script from tail window recalculates ram usage
2022-09-23 00:35:26 -03:00
hydroflame
e65a00daef
Merge pull request #4088 from Kelenius/BladeburnerUIExtraLinesRemoval
UI: Removed three empty lines from BB status screen
2022-09-23 00:34:47 -03:00
hydroflame
e647ebb00f
Merge pull request #4085 from hex7cd/bn7-descr-fix
UI: Add missing space to BN7 description
2022-09-23 00:34:37 -03:00
hydroflame
e49bd3d091
Merge branch 'dev' into feature/add-back-api-export 2022-09-23 00:34:19 -03:00
hydroflame
34534ac282
Merge pull request #4093 from coderanger/sleeve-heal
SLEEVES: FIX #3819 Allow using the regeneration chamber with sleeves to heal them.
2022-09-23 00:33:16 -03:00
hydroflame
c449680256
Merge pull request #4104 from Mughur/dev
MISC: multiple hasAugmentation checks didn't check if the augment was installed
2022-09-23 00:32:16 -03:00
hydroflame
7749b17a45
Merge pull request #4120 from SilverNexus/dev
UI: FIX #4106 Fix incorrect experience display in Crime UI.
2022-09-23 00:31:00 -03:00
Mughur
d4c06eba24 Change corporatio valuation calculations 2022-09-23 05:05:18 +03:00
hydroflame
cc78d62b26
Merge pull request #4121 from phyzical/bugfix/4096
API FIX: getCrimeStats use bitnode multipliers in the output of crime stats
2022-09-22 18:22:54 -03:00
phyzical
4175960fc6
use bitnode multiplers in the output of crime stats 2022-09-20 17:56:05 +08:00
SilverNexus
10a2f180ce Fix #4106 -- Crime EXP is exactly One Fifth? 2022-09-19 20:23:26 -04:00
Mughur
4c5adc8dfb More hasAugmentation fixes 2022-09-14 21:21:49 +03:00
Mughur
75c738cdb0 Fixed NMI aug having effect before installing 2022-09-14 20:54:03 +03:00
G4mingJon4s
22a35af6b6 Added hover style change for better recognition 2022-09-14 15:59:55 +02:00
Mughur
4b859131b4 TRP message is sent only after installing 2022-09-14 16:14:32 +03:00
Mughur
d16576f3a7 TRP message is sent only after installing 2022-09-14 15:49:50 +03:00
G4mingJon4s
c29b4cfda9 Fixes #2795, adding better underlines for links 2022-09-13 20:09:58 +02:00
G4mingJon4s
015fb46703 Fix for #2442, allowing going forward in tutorial 2022-09-13 17:58:47 +02:00
Kelenius
5350e1c3e9 Unhardcoded BN8 BB check; show if corp/BB are disabled in BN stats 2022-09-12 17:48:52 +03:00
Noah Kantrowitz
e4961f452e ✏️ Copy paste typo. 2022-09-10 17:52:06 -07:00
Noah Kantrowitz
232dcab5cd Reset sleeves to max HP when starting a new node. 2022-09-10 17:44:50 -07:00
Noah Kantrowitz
596a04515d Allow using the regeneration chamber with sleeves to heal them.
This also allows using sleeves to generate stamina faster even if at full HP.
2022-09-10 17:39:40 -07:00
Kelenius
aeedcad96d Removed three empty lines from BB status screen 2022-09-07 13:12:40 +03:00
phyzical
ca2f1a62a5
add singularity function for exporting game save 2022-09-07 16:11:51 +08:00
Simon Schuck
0ffde31712
Add missing space to BN7 description
Before: allows you to access Bladeburnersfunctionality through
After: allows you to access Bladeburners functionality through
2022-09-06 06:27:33 +02:00
Rasmoh
cc0fd197c5 Expose exports from Material 2022-09-05 17:25:32 -07:00
Snarling
a600e05c0d Fix typo 2022-09-05 08:29:03 -04:00
Snarling
51d019c16c Decache Ram on Tail Run 2022-09-05 08:19:24 -04:00
Zoë Hoekstra
c7573cd97b
Remove unused imports. 2022-09-02 19:19:00 +02:00
Zoë Hoekstra
335eab0f14
tryWritePort now also uses helper function 2022-09-02 19:14:56 +02:00
phyzical
2a8ddb8147
fix up param order to match docs
hotfix/4058

File List:
src/NetscriptFunctions/Corporation.ts
2022-09-02 11:58:12 +08:00
Zoë Hoekstra
d6e5b45db1
Delete now outdated comment 2022-09-01 16:53:58 +02:00
Zoë Hoekstra
10a1c2f00d
Lower limit to MAX_SAFE_INTEGER 2022-09-01 16:33:31 +02:00
Zoë Hoekstra
55df97d3d5
Format 2022-09-01 16:27:31 +02:00
Zoë Hoekstra
ec81fb60c3
Create ports on demand. Increase max to infinity. 2022-09-01 16:13:10 +02:00
Snarling
137f58c36d actually exitOnExit 2022-09-01 08:37:59 -04:00
Snarling
1be015898c exitExits 2022-09-01 08:23:31 -04:00
Olivier Gagnon
2592c6ccd8 allbuild commit 87054f61 2022-08-31 12:26:02 -04:00
Mughur
c467a49a38 corp functions now return copy instead of original 2022-08-31 12:05:36 +03:00
Snarling
e8c8bb76ff Don't let sleeve start invalid contract 2022-08-30 09:26:24 -04:00
Olivier Gagnon
2675fd23ec fix stack trace missing in some errors 2022-08-29 18:14:54 -04:00
Olivier Gagnon
c9a0998cc1 Improve wrong arg user message and add ui.windowSize 2022-08-29 18:07:17 -04:00
Olivier Gagnon
759de85559 Fix unique key problem with ascii elements 2022-08-29 16:59:38 -04:00
Olivier Gagnon
c88ac1c26e fix some stuff with the timestamp settings 2022-08-29 16:47:51 -04:00
Olivier Gagnon
e57fee00d2 fix some stuff with the timestamp settings 2022-08-29 16:45:07 -04:00
Olivier Gagnon
3fe6a6e19d fix settings unfocusing on every key stroke 2022-08-29 16:36:08 -04:00
Olivier Gagnon
fb372bef54 fix documentation for remote api 2022-08-29 15:57:37 -04:00
Olivier Gagnon
b5a2319df7 Refactor game options into separate components 2022-08-29 15:56:38 -04:00
Olivier Gagnon
f07a29c73b fix dynamic ram miscalc not triggering 2022-08-29 15:26:34 -04:00
Olivier Gagnon
04f811276a allbuild commit a0475cc6 2022-08-29 10:35:30 -04:00
hydroflame
a0475cc630
Merge pull request #4049 from MPJ-K/dev
NETSCRIPT: FIX #3963 Prevent bladeburner.setActionLevel from setting invalid action levels
2022-08-29 11:20:28 -03:00
hydroflame
69f6ca364f
Merge pull request #4040 from Mughur/dev
DOCS, UI: update docs a bit more, amending some BN and SF texts
2022-08-29 11:20:10 -03:00
hydroflame
44ab53653f
Merge pull request #4041 from Mughur/sleeve
SLEEVE: FIX #4022, #4024, #4025, #3998
2022-08-29 11:18:01 -03:00
hydroflame
c2796e164a
Merge pull request #4052 from Snarling/ns1wrapper
NETSCRIPT: FIX #4037 ns1 wraps deeper layers correctly.
2022-08-29 11:14:32 -03:00
Olivier Gagnon
0942b7b6ee minor fix in instance calculation 2022-08-29 10:06:20 -04:00
hydroflame
2f7463d092
Merge pull request #4062 from Snarling/sleevesQuitToo
SLEEVES: FIX #4051 Sleeves no longer crash when player quits company sleeve was working
2022-08-29 11:05:27 -03:00
hydroflame
6fc729ddfb
Merge pull request #4060 from ezylot/patch-2
INFILTRATION: Corrected ns formula for infiltration rewards
2022-08-29 11:04:11 -03:00
hydroflame
de12893da6
Merge pull request #4056 from Snarling/dynamicRamCheckFix
NETSCRIPT: FIX #4055 Fix dynamic ram check
2022-08-29 10:57:33 -03:00
Snarling
9d942f3393 sleevesActuallyQuitToo 2022-08-29 04:12:02 -04:00
Snarling
c2af87a769 sleevesQuitToo 2022-08-29 04:02:38 -04:00
Florian Schöffl
282dc28c8d
INFILTRATION: Corrected ns formula for infiltration rewards
In commit 
7c5097ee83d9e2d185960a9c96739a78981bd600 the author extracted the functionality for infiltration rewards into a NS function and made it accessible via formulas.

The exposed function does however not use the same input parameters as the Victory screen after infiltration since he uses the difficulty and not the starting difficulty.

Difficulty is clamped to [0;3], so the formulas api showed for high difficulty servers a vastly lower result.
2022-08-29 02:35:39 +02:00
Zoë Hoekstra
793255aecd
Remove replacement of "export " to "" 2022-08-28 22:39:01 +02:00
Snarling
185549e7e4 fix dynamic ram check 2022-08-28 07:44:41 -04:00
Mughur
cf09057836 BB action rewards now tied to who does the action 2022-08-28 13:20:27 +03:00
Mughur
ce5d777f59
Merge branch 'danielyxie:dev' into sleeve 2022-08-28 10:47:49 +03:00
Mughur
1724f0e3ff
Merge branch 'danielyxie:dev' into dev 2022-08-28 10:47:40 +03:00
Snarling
ef1f376c09 format, lint, remove unused "running" property on ws 2022-08-27 22:32:48 -04:00
Snarling
6f36e9cdc5 Fix/Unify NS1 wrapper 2022-08-27 20:56:12 -04:00
Olivier Gagnon
1fdc36b1e7 Merge branch 'dev' of github.com:danielyxie/bitburner into dev 2022-08-26 17:49:54 -04:00
Olivier Gagnon
5f41226c21 Fix scp and write in ns1 2022-08-26 17:49:27 -04:00
MPJ / Quadryo
197081dd3e
Fix #3963
Adds a previously missing `throw` to allow `bladeburner.setActionLevel()` to properly produce errors and prevent invalid action levels from being set.
2022-08-26 20:59:26 +02:00
Kelenius
e16140fe9c Improvements to crime work UI 2022-08-26 21:03:30 +03:00
Zoë Hoekstra
45c15c9953
Extract result type and correct it for getAllFiles 2022-08-26 11:31:37 +02:00
Zoë Hoekstra
ceb4a05289
Fix type of RFAMessages with non-String results 2022-08-26 11:17:47 +02:00
Mughur
7b7858d8e3 Only the wanted commits this time 2022-08-26 12:03:25 +03:00
Mughur
e361866ab8
Merge branch 'danielyxie:dev' into sleeve 2022-08-26 00:35:05 +03:00
Mughur
9d1b48e076 Fixing my previous mistakes 2022-08-26 00:30:27 +03:00
hydroflame
2463fc2012
Merge pull request #4028 from Snarling/scpAndWriteDocFix
NETSCRIPT: Update netscript definition file for scp, write, read, and flags
2022-08-25 16:37:07 -03:00
hydroflame
e554a6ac13
Merge pull request #4027 from Snarling/ANSIFix
TERMINAL: Fix ansi display bugs
2022-08-25 16:35:44 -03:00
Mughur
a6d4ef4147 sleeve.getTask() retuns which crime name 2022-08-25 20:28:05 +03:00
Mughur
1a1decf5fd sleeve BB contracts now properly give money 2022-08-25 20:06:19 +03:00
Mughur
bf33734def Sleeve shock goes down, but not to negative 2022-08-25 18:49:01 +03:00
Mughur
2e4e7fadfc fix Sleeve UI gains 2022-08-25 18:19:14 +03:00
Mughur
c5cbbb2fbd fix sleeve bb 2022-08-25 17:23:14 +03:00
Mughur
fa9f34aba2 update docs a bit more 2022-08-25 14:47:31 +03:00
Florian Schöffl
0c93764ef8
Added weight to GangMemberTask construction call
Added hackWeight: 100 to GangMember Task construction call to prevent error messages from the constructor checks. 
Since we only compare with roughlyIs() this will have no impact on functionality
2022-08-25 11:08:33 +02:00
Duck McSouls
84eabad6ac Typo fixes in CodingContract, Hacknet, and Singularity.
Fix some typographical errors in the CodingContract, Hacknet, and Singularity APIs.  I have yet to look over other APIs, but I don't want to make the patch any larger than it currently is.
2022-08-25 10:52:24 +10:00
Snarling
d1aa114e29 Fix build error / additional type for flags 2022-08-24 20:28:38 -04:00
Snarling
650db2dee7 Add type fix for flags 2022-08-24 19:09:18 -04:00
Snarling
bba9317ef6 incorporate read changes 2022-08-24 18:42:42 -04:00
MycroftJr
1135508683 fix ns.read return type 2022-08-24 18:36:50 -04:00
Derek H Osborne
6e02a70eea Removed console.log line 2022-08-24 17:22:16 -05:00
Alain Bryden
359def2b61
Don't stringify answer if already a string 2022-08-24 11:09:35 -03:00
Duck McSouls
d38ef01a94 A typo fix.
Fix a typographical error.  From a first time contributor.
2022-08-24 13:57:42 +10:00
Snarling
4d47785f28 Fix ns documentation for scp and write 2022-08-23 22:06:05 -04:00
Snarling
d8c1ac9176 lint 2022-08-23 18:27:37 -04:00
Snarling
2d8900408d Fix Ansi bugs 2022-08-23 17:54:13 -04:00
Olivier Gagnon
076d79ed5a Merge branch 'dev' of github.com:danielyxie/bitburner into dev 2022-08-23 17:51:34 -04:00
Olivier Gagnon
3d8616b3a7 Did some changes of the remote api and added documentation 2022-08-23 17:50:31 -04:00
Snarling
445e365959 debounce updateRAM 2022-08-23 16:38:30 -04:00
Olivier Gagnon
89aa23f4b3 Add dummy function to generate a mock server or player for formulas stuff 2022-08-23 16:01:34 -04:00
hydroflame
895944aa19
Merge pull request #3972 from Hoekstraa/rfa
RFA: New Remote File API addition for transmitting files to the game
2022-08-23 16:09:29 -03:00
Olivier Gagnon
a41a6db520 allbuild commit f825cc0b 2022-08-23 12:48:51 -04:00
Olivier Gagnon
7cb48f4612 fix compile error 2022-08-23 12:04:09 -04:00
hydroflame
fe3e34408d
Merge branch 'dev' into dev 2022-08-23 13:01:13 -03:00
hydroflame
604596b907
Merge pull request #3480 from Undeemiss/corp-new-shares
CORPORATION: Limit shareholder priority on newly issued shares
2022-08-23 12:55:09 -03:00
hydroflame
486ab7aad8
Merge branch 'dev' into contractFix 2022-08-23 12:44:21 -03:00
Olivier Gagnon
0e569344e7 rm console log 2022-08-23 11:28:40 -04:00
hydroflame
67be694b68
Merge pull request #3978 from Snarling/atExitFix
NETSCRIPT: FIX #2931 atExit now allows synchronous ns functions
2022-08-23 12:27:43 -03:00
hydroflame
d553a1d2f4
Merge pull request #3981 from Snarling/B&AFix
FILES: FIX #3979 Allow characters & and ' in filenames
2022-08-23 12:25:55 -03:00
hydroflame
849046df3a
Merge pull request #3985 from Snarling/synchronize
NETSCRIPT: ns.scp and ns.write are now synchronous + fix exec race condition
2022-08-23 12:25:24 -03:00
hydroflame
46f5640dcd
Merge pull request #3976 from Snarling/ScriptEditorResponsiveness
UI: FIX #3975, #3882 Script Editor more responsive on resize, and fix dirty file indicator
2022-08-23 12:12:21 -03:00
hydroflame
fc7eb72fc0
Merge pull request #3980 from phyzical/hotfix/3977
CORP FIX: dont take research points for something already researched via api
2022-08-23 12:11:15 -03:00
hydroflame
6969ff52c7
Merge pull request #4010 from Risenafis/fix-create-corp
NETSCRIPT: Correct missing ! for boolean coercion in Corporation.createCorporation().
2022-08-23 12:10:49 -03:00
hydroflame
3e3177d7bd
Merge pull request #4001 from Mughur/dev
MISC: Sleeve crime gain bitnode multiplier fix
2022-08-23 12:10:27 -03:00
hydroflame
1d3eb2ffb5
Merge pull request #4000 from MageKing17/patch-2
NETSCRIPT: Correct missing `!` for boolean coercion in `singularity.workForCompany()`.
2022-08-23 12:09:49 -03:00
hydroflame
ed76c5e15d
Merge pull request #4019 from MageKing17/patch-4
API: All the player sub-objects need to be copied for `getPlayer`.
2022-08-23 12:07:34 -03:00
hydroflame
01b5ba1be5
Merge pull request #4012 from MageKing17/patch-3
DOCS: Correct documentation for `run()` with 0 threads.
2022-08-23 12:07:19 -03:00
hydroflame
cc29de7969
Merge pull request #4002 from RollerKnobster/hotfix/3992-toast-handle-null-duration
NETSCRIPT: fix #3992 allow null duration in toast ns function
2022-08-23 12:06:56 -03:00
hydroflame
7269919aa9
Merge pull request #4023 from Snarling/companyWorkSingFix
WORK: Add singularity check for finishing company work
2022-08-23 12:05:44 -03:00
Snarling
d4c7edf351 Fix fullscreen pages 2022-08-23 02:37:53 -04:00
Snarling
c626377904 Add singularity check for finishing company work 2022-08-22 20:16:45 -04:00
MageKing17
80aafc7d48
All the player sub-objects need to be copied.
Not just `mults`. Also, `hacking_chance_mult` still being at the base level appears to be a mistake.
2022-08-21 12:22:58 -07:00
MageKing17
0a4c64a8fa Correct documentation for run() with 0 threads.
For consistency, the same phrasing has been applied to the documentation for `exec()` and `spawn()`.
2022-08-20 18:47:37 -07:00
Snarling
5466ab3f69 format+lint 2022-08-20 19:16:11 -04:00
Snarling
7578860ce7 remove more prop chaining 2022-08-20 19:14:54 -04:00
Snarling
0f15431b5f remove unused eventEmitterForUiReset 2022-08-20 19:08:05 -04:00
Snarling
97961d6896 Reduce prop chaining 2022-08-20 18:52:18 -04:00
Snarling
9d5cf89f68 Remove prop chain for cancelOrder + format 2022-08-20 18:40:21 -04:00
Risenafis
b224321222
fix selfFund was reversed 2022-08-20 23:37:39 +09:00
Snarling
2aca8476b6 cancelOrder Params
Why is this defined in so many places
2022-08-19 19:49:09 -04:00
Snarling
4001b4cbb0 refactor stock for ctx instead of workerScript 2022-08-19 19:32:30 -04:00
Snarling
1dc1a7ed6f lint 2022-08-19 18:36:24 -04:00
Snarling
823cdf70ca Fix compile race conditions 2022-08-19 18:21:31 -04:00
Roman Ivaniuk
5c0c130b4b 3992 Fix: handle null duration in toast ns function
extend SnackbarEvents typing to allow null in third argument
also remove typos in Electron.tsx init functions comments
2022-08-19 14:38:46 +03:00
Mughur
84e2ae78c3 Sleeve crime gain bitnode multiplier fix 2022-08-19 10:03:20 +03:00
MageKing17
28d7284323
Correct missing ! for boolean coercion.
`singularity.workForCompany()` was negating its `_focus` argument, unlike similar functions, which used double-negation to coerce to boolean. This was almost certainly a typo, since before PR-#3967 it used `_ctx.helper.boolean()` without negation, just like the other singularity functions.
2022-08-18 22:04:11 -07:00
MageKing17
1b8993a3dc
Replace "stock.short" with "stock.shortStock".
This was preventing `disableLog("ALL")` from stopping these log messages, since that's not the function's name now.
2022-08-18 13:29:21 -07:00
Olivier Gagnon
3067703c63 Trying to fix int bug 2022-08-18 13:40:39 -04:00
Olivier Gagnon
a88f14cd16 Fix broken ns filenames 2022-08-18 12:36:30 -04:00
Snarling
07e9cb9277 refactor scp function 2022-08-17 20:31:26 -04:00
Snarling
f6a8d5d337 synchronize scp and write 2022-08-17 18:55:12 -04:00
Snarling
95a1c18139 synchronize write and scp 2022-08-17 17:11:59 -04:00